Subject: [PATCH 12/18] OMAP3 : clock data: Update name string for EMAC clocks

From: [email-masked] (Tony Lindgren)
Date: Wed, 5 May 2010 13:02:23 -0700

* Russell King - ARM Linux <[email-masked]> [100505 12:41]:
> On Wed, May 05, 2010 at 12:33:09PM -0700, Tony Lindgren wrote:
> > The emac driver uses generic name for the module and phy
> > clocks. Updated the omap3xxx_clks table to match the names
> > used by the Davinci emac driver.
> 
> Patch doesn't match description.

Sriramakrishnan, can you please update the patch for better
description?

> IMHO "ick" and "fck" are generic names, whereas "emac_clk" and
> "phy_clk" are specific names.
> 
> > -	CLK("davinci_emac",	"ick",		&emac_ick,	CK_AM35XX),
> > -	CLK("davinci_emac",	"fck",		&emac_fck,	CK_AM35XX),
> > +	CLK("davinci_emac",	"emac_clk",	&emac_ick,	CK_AM35XX),
> > +	CLK("davinci_emac",	"phy_clk",	&emac_fck,	CK_AM35XX),

Yeah as Paul pointed out too, there should be a follow-up patch
to fix there clock names in drivers/net/davinci_emac.c, mach-davinci/dm646x.c,
mach-davinci/da850.c, and mach-omap2/clock3xxx_data.c.

That should also be mentioned in the patch description.

Regards,

Tony