From: ben-linux@fluff•org (Ben Dooks)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 05/16] ARM: S5PC100: new clocks definition
Date: Thu, 13 May 2010 01:59:10 +0100 [thread overview]
Message-ID: <20100513005910.GO6684@trinity.fluff.org> (raw)
In-Reply-To: <000301caf1ae$72b04a80$5810df80$%szyprowski@samsung.com>
On Wed, May 12, 2010 at 10:37:59AM +0200, Marek Szyprowski wrote:
> Hello,
>
> On Wednesday, May 12, 2010 9:34 AM Kukjin Kim wrote:
>
> > ...
> > > >
> > > > Marek,
> > > >
> > > > Actually, need to modify many part to fit new clock scheme.
> > > > For example, to use clksrc_clk is easily to handle clock.
> > >
> > > I thought I covered most of the changes. Probably only the armclk
> > > related functions and a cleanup in s5pc100/mach/regs-clock.h are
> > > left and these can be easily fixed.
> > >
> > > > S.LSI already made the patch for C100 clock changing which is using
> > > > clksrc_clk structure. So may I submit it?
> > >
> > > Could you compare your version with the final version that is created
> > > by my patch series? I don't think that there will be many differences
> > > there.
> > >
> >
> > There are defined clock source of C100 available clock in SYS.LSI patch
> > like
> > clocks defined by CLK_SRC1 register.
> > SYS.LSI has covered all possible C100 clocks in our patch.
>
> So this is rather a question of general policy about the clocks. Do we
> really need to define them even if no driver would use it? I'm not
> convinced. On the other hand defining all clocks now may reduce the driver
> development time in the future.
I've not really got a policy on this, when adding new SoC support I
much prefer to see what is needed to get the archicture core up before
adding lots of clocks.
> > So I think SYS.LSI patch provides more functionality based on Ben Dooks'
> > new clock scheme.
> >
> > How about check/review it after my submitting?
>
> Maybe it would be possible to adapt it in such a way that it would be an
> extension to the clocks defined by my patch series?
>
> Ben, what do you think? Which way should we go?
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-05-13 0:59 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 6:48 [PATCH] ARM: Samsung: S5PC100 platform cleanup Marek Szyprowski
2010-04-02 6:48 ` [PATCH 01/16] ARM: S5PC1xx rename registers to match plat-s5p style Marek Szyprowski
2010-05-12 4:55 ` Kukjin Kim
2010-05-12 5:33 ` Marek Szyprowski
2010-05-13 0:54 ` Ben Dooks
2010-04-02 6:48 ` [PATCH 02/16] drivers: serial: S5PC100 serial driver cleanup Marek Szyprowski
2010-04-06 15:59 ` Ben Dooks
2010-04-08 8:08 ` Marek Szyprowski
2010-04-02 6:48 ` [PATCH 03/16] ARM: Samsung: plat-s5p - enable access to clk_27m clock Marek Szyprowski
2010-05-12 4:55 ` Kukjin Kim
2010-05-12 16:14 ` Marek Szyprowski
2010-04-02 6:48 ` [PATCH 04/16] ARM: S5PC100: copy clocks from plat-s5pc1xx Marek Szyprowski
2010-05-12 4:55 ` Kukjin Kim
2010-05-12 5:22 ` Marek Szyprowski
2010-04-02 6:48 ` [PATCH 05/16] ARM: S5PC100: new clocks definition Marek Szyprowski
2010-05-12 4:56 ` Kukjin Kim
2010-05-12 6:43 ` Marek Szyprowski
2010-05-12 7:34 ` Kukjin Kim
2010-05-12 8:37 ` Marek Szyprowski
2010-05-12 8:48 ` Jassi Brar
2010-05-13 0:59 ` Ben Dooks [this message]
2010-05-12 17:48 ` Marek Szyprowski
2010-05-13 0:22 ` Kukjin Kim
2010-04-02 6:48 ` [PATCH 06/16] ARM: Samsung: move S5PC100 support from plat-s5pc1xx to plat-s5p framework Marek Szyprowski
2010-05-12 5:41 ` Kukjin Kim
2010-05-12 5:54 ` Marek Szyprowski
2010-05-12 6:31 ` jassi brar
2010-05-12 6:40 ` Marek Szyprowski
2010-05-12 6:57 ` jassi brar
2010-04-02 6:48 ` [PATCH 07/16] ARM: S5PC100: Move gpio support from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-12 5:50 ` Kukjin Kim
2010-05-12 6:02 ` Marek Szyprowski
2010-05-13 1:05 ` Ben Dooks
2010-04-02 6:48 ` [PATCH 08/16] ARM: S5PC100: Move frame buffer helpers " Marek Szyprowski
2010-05-12 5:52 ` Kukjin Kim
2010-05-12 6:08 ` Marek Szyprowski
2010-04-02 6:48 ` [PATCH 09/16] ARM: SMDKC100: enable frame buffer again Marek Szyprowski
2010-05-12 5:55 ` Kukjin Kim
2010-04-02 6:48 ` [PATCH 10/16] ARM: S5PC100: Move i2c helpers from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-12 6:05 ` Kukjin Kim
2010-04-02 6:48 ` [PATCH 11/16] ARM: SMDKC100: enable i2c support again Marek Szyprowski
2010-05-12 6:06 ` Kukjin Kim
2010-04-02 6:49 ` [PATCH 12/16] ARM: S5PC100: Move sdhci helpers from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-12 7:04 ` Kukjin Kim
2010-05-12 7:24 ` Marek Szyprowski
2010-04-02 6:49 ` [PATCH 13/16] ARM: SMDKC100: enable sdhci support again Marek Szyprowski
2010-05-12 7:05 ` Kukjin Kim
2010-04-02 6:49 ` [PATCH 14/16] ARM: Samsung: Move external interrupts support from plat-s5pc1xx to plat-s5p Marek Szyprowski
2010-04-02 6:49 ` [PATCH 15/16] ARM: S5PC100: Add support for gpio interrupt Marek Szyprowski
2010-04-02 6:49 ` [PATCH 16/16] ARM: remove obsolete plat-s5pc1xx directory Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513005910.GO6684@trinity.fluff.org \
--to=ben-linux@fluff$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox