From: baruch@tkos•co.il (Baruch Siach)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] mx25: add watchdog clock
Date: Thu, 10 Jun 2010 11:27:56 +0300 [thread overview]
Message-ID: <20100610082756.GD31840@jasper.tkos.co.il> (raw)
In-Reply-To: <20100610082145.GC5333@pengutronix.de>
Hi Wolfram,
On Thu, Jun 10, 2010 at 10:21:45AM +0200, Wolfram Sang wrote:
> On Thu, Jun 10, 2010 at 11:18:06AM +0300, Baruch Siach wrote:
> > On Thu, Jun 10, 2010 at 10:10:42AM +0200, Wolfram Sang wrote:
> > > On Wed, Jun 09, 2010 at 02:07:00PM +0300, Baruch Siach wrote:
> > > > Signed-off-by: Baruch Siach <baruch@tkos•co.il>
> > > > ---
> > > > arch/arm/mach-mx25/clock.c | 2 ++
> > > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/arch/arm/mach-mx25/clock.c b/arch/arm/mach-mx25/clock.c
> > > > index 1550149..f9662d9 100644
> > > > --- a/arch/arm/mach-mx25/clock.c
> > > > +++ b/arch/arm/mach-mx25/clock.c
> > > > @@ -191,6 +191,7 @@ DEFINE_CLOCK(i2c_clk, 0, CCM_CGCR0, 6, get_rate_i2c, NULL, NULL);
> > > > DEFINE_CLOCK(fec_clk, 0, CCM_CGCR1, 15, get_rate_ipg, NULL, &fec_ahb_clk);
> > > > DEFINE_CLOCK(dryice_clk, 0, CCM_CGCR1, 8, get_rate_ipg, NULL, NULL);
> > > > DEFINE_CLOCK(lcdc_clk, 0, CCM_CGCR1, 29, get_rate_lcdc, NULL, &lcdc_per_clk);
> > > > +DEFINE_CLOCK(wdt_clk, 0, CCM_CGCR1, 19, get_rate_ipg, NULL, NULL);
> > >
> > > That is clk_gpt1 according to my RM (Rev 1)?
> >
> > Right. It should be CCM_CGCR2. I'll fix this.
> >
> > Note that this bit is marked "Reserved" in the RM. But a look at the Freescale
> > supplied BSP reveals the following line in crm_regs.h:
> >
> > #define MXC_CCM_CGCR2_WDOG_OFFSET (51-32)
>
> OK. Please add this information also in a short comment above the clock
> definition.
There are 12 other IPG clock bit that are wrongly marked "Reserved" in the RM.
Should we add a comment for each?
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2010-06-10 8:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 11:06 [PATCH 0/3] MX25 watchdog Baruch Siach
2010-06-09 11:07 ` [PATCH 1/3] mx25: add watchdog clock Baruch Siach
2010-06-10 8:10 ` Wolfram Sang
2010-06-10 8:18 ` Baruch Siach
2010-06-10 8:21 ` Wolfram Sang
2010-06-10 8:27 ` Baruch Siach [this message]
2010-06-10 8:34 ` Wolfram Sang
2010-06-10 8:45 ` Baruch Siach
2010-06-10 9:32 ` [PATCH] " Baruch Siach
2010-06-09 11:07 ` [PATCH 2/3] mx25pdk: register watchdog device Baruch Siach
2010-06-09 11:07 ` [PATCH 3/3] imx2_wdt: fix section mismatch Baruch Siach
2010-06-09 19:17 ` Uwe Kleine-König
2010-06-10 11:25 ` Wim Van Sebroeck
2010-06-10 9:18 ` [PATCH 0/3] MX25 watchdog Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610082756.GD31840@jasper.tkos.co.il \
--to=baruch@tkos$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox