public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: pieterg@gmx•com (pieterg)
To: linux-arm-kernel@lists•infradead.org
Subject: machine definition for colibri-pxa3xx
Date: Thu, 8 Jul 2010 12:36:39 +0200	[thread overview]
Message-ID: <201007081236.39550.pieterg@gmx.com> (raw)

At the moment, colibri-pxa300.c as well as colibri-pxa320.c have their own 
machine definition.

However, running a kernel built with CONFIG_MACH_COLIBRI300 and 
CONFIG_MACH_COLIBRI320 on a colibri 300 or 310, it will match the 320 
machine definition, and therefore use colibri-pxa320.c.

I believe it's not possible to differentiate colibri pxa3xx based on machine 
definitions, but only by checking the their cpu.

Wouldn't it make sense to place a single "Toradex Colibri PXA3xx" machine 
definition in colibri-pxa3xx.c, and use cpu_is_pxa3nn to do cpu specific 
initialisation?
This is exactly how things are done for zylonite by the way.

I have some colibri pxa310 patches, but we need a working machine detection 
before they will actually do anything.

Rgds, Pieter

             reply	other threads:[~2010-07-08 10:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08 10:36 pieterg [this message]
2010-07-08 12:06 ` machine definition for colibri-pxa3xx Marek Vasut
2010-07-08 12:55   ` pieterg
2010-07-08 15:18     ` Marek Vasut
2010-07-08 15:59       ` pieterg
2010-07-08 20:07         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007081236.39550.pieterg@gmx.com \
    --to=pieterg@gmx$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox