Subject: [PATCH v2 5/5] colibri-pxa3xx: add touchscreen support

From: [email-masked] (Arnd Bergmann)
Date: Fri, 9 Jul 2010 18:14:24 +0200

On Friday 09 July 2010, pieterg wrote:
> > > --- a/arch/arm/mach-pxa/include/mach/colibri.h
> > > +++ b/arch/arm/mach-pxa/include/mach/colibri.h
> > > @@ -30,6 +30,12 @@ extern void colibri_pxa3xx_init_nand(void);
> > >  static inline void colibri_pxa3xx_init_nand(void) {}
> > >  #endif
> > >
> > > +#if defined(CONFIG_INPUT_TOUCHSCREEN)
> > > +extern void colibri_pxa3xx_init_touchscreen(void);
> > > +#else
> > > +static inline void colibri_pxa3xx_init_touchscreen(void) {}
> > > +#endif
> > > +
> > >  /* physical memory regions */
> > >  #define COLIBRI_SDRAM_BASE 0xa0000000      /* SDRAM region */
> >
> > What will happen if both of the TS devices are selected?
> 
> That's no problem.
> I actually have both configs enabled, so I can run the same kernel on the 
> 310 (which is using wm97 for a while now) and the 320 (which still has 
> ucb1400 at the moment)

But doesn't the code still create both devices in /sys/devices/platform then?
AFAICT, there is no runtime probing support to make sure you only register
the device that is there.

	Arnd