From: pavel@ucw•cz (Pavel Machek)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] pxa/spitz: Rework spitz
Date: Fri, 9 Jul 2010 21:07:41 +0200 [thread overview]
Message-ID: <20100709190741.GA1669@ucw.cz> (raw)
In-Reply-To: <201006111752.08130.marek.vasut@gmail.com>
Hi!
> > > > 1) Made every part modular, components are not built in if not
> > > > selected. 2) Removed loads of preprocessor goo, mostly "#ifdef
> > > > MACH_AKITA .... #endif" and similar code. The kernel size will grow by
> > > > a few kb now, but the file is much more readable.
> > > > 3) Reworked SD/CF power setting function and made it reentrant.
> > > >
> > > > Signed-off-by: Marek Vasut <marek.vasut@gmail•com>
> > > > ---
> > > >
> > > > arch/arm/mach-pxa/include/mach/spitz.h | 2 -
> > > > arch/arm/mach-pxa/spitz.c | 748
> > > >
> > > > ++++++++++++++++++-------------- 2 files changed, 420 insertions(+),
> > > > 330 deletions(-)
> > >
> > > Pavel, Eric, I tested this on metan's Z, could you give it a go ?
> >
> > quick test on 2.6.35-rc2 (of the 2nd version), and all seems
> > well. What should I look for?
>
> Nothing, the functionality should be the same ... I just felt like it needs
> rework, it was frustrating digging in it in the state it is in now. The way it
> is now it's much easier to hack on it. There are still open issues:
>
> 1) CPUfreq on Zaurus is still broken. (doesn't work on other devices - causes
> freezes)
> 2) PCMCIA driver looses interrupts. (pcmcia-sharpsl needs rework)
hda timeouts?
> 3) We need driver for the CPU PMIC. (I already wrote it)
Can you cc me on that one? That should fix the random segfaults, right?
> 4) Weird mess on the LCD when using DMA (also happens on other devices)
>
> So we'll have at least another four following patches sometimes later.
>
> Pavel, can we get this in? Can I get your Ack and get this one applied? Thanks
Sorry, I was busy... 2) mixes all kinds of things together -- it would
be better to split such patches in future, but yes, it looks ok.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-07-09 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 6:45 [PATCH 1/2] ARM/scoop: Add CPR register bit definitions Marek Vasut
2010-06-11 6:45 ` [PATCH 2/2] pxa/spitz: Rework spitz Marek Vasut
2010-06-11 6:52 ` Marek Vasut
2010-06-11 14:36 ` Pavel Machek
2010-06-11 15:52 ` Marek Vasut
2010-07-09 19:07 ` Pavel Machek [this message]
2010-07-09 19:46 ` Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2010-06-11 13:17 [PATCH 1/2] ARM/scoop: Add CPR register bit definitions Marek Vasut
2010-06-11 13:17 ` [PATCH 2/2] pxa/spitz: Rework spitz Marek Vasut
2010-06-13 11:44 [PATCH 1/2] ARM/scoop: Add CPR register bit definitions Marek Vasut
2010-06-13 11:44 ` [PATCH 2/2] pxa/spitz: Rework spitz Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709190741.GA1669@ucw.cz \
--to=pavel@ucw$(echo .)cz \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox