From: robert.richter@amd•com (Robert Richter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/3] stop OProfile calling arch_exit when arch_init fails
Date: Tue, 31 Aug 2010 13:01:52 +0200 [thread overview]
Message-ID: <20100831110152.GD22783@erda.amd.com> (raw)
In-Reply-To: <1283107921-21464-1-git-send-email-will.deacon@arm.com>
On 29.08.10 14:51:58, Will Deacon wrote:
> These patches remove the oprofile_arch_exit call from oprofile_init,
> allowing architectures that perform memory allocation in their init
> functions to be simplified. This requires some changes to the ARM and
> x86 OProfile backends to ensure that their init functions clean up
> after themselves if they fail.
>
> This is required for Matt's combined OProfile/Perf driver which will
> be shared between all architectures.
>
> Patches taken against tip/master.
>
> Cc: Robert Richter <robert.richter@amd•com>
> Cc: Matt Fleming <matt@console-pimps•org>
> Cc: Peter Zijlstra <peterz@infradead•org>
> Cc: Ingo Molnar <mingo@elte•hu>
>
> Will Deacon (3):
> oprofile: don't call arch exit code from init code on failure
> ARM: oprofile: fix and simplify init/exit functions
> x86: oprofile: fix oprofile_arch_init behaviour on failure
>
> arch/arm/oprofile/common.c | 47 +++++++++++++++++++++++--------------------
> arch/x86/oprofile/init.c | 26 ++++++++++++++----------
> drivers/oprofile/oprof.c | 11 +--------
> 3 files changed, 42 insertions(+), 42 deletions(-)
I have applied patch #1 and #2 to
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git core
with some small modifications:
Patch #1: Commit message, x86 removed.
Patch #2: Order of freeing memory:
+out:
+ if (ret) {
+ for_each_possible_cpu(cpu)
+ kfree(perf_events[cpu]);
+ kfree(counter_config);
+ }
+
There is also the patch below on top of it.
Thanks Will,
-Robert
--
prev parent reply other threads:[~2010-08-31 11:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 18:51 [PATCH 0/3] stop OProfile calling arch_exit when arch_init fails Will Deacon
2010-08-29 18:51 ` [PATCH 1/3] oprofile: don't call arch exit code from init code on failure Will Deacon
2010-08-29 18:52 ` [PATCH 2/3] ARM: oprofile: fix and simplify init/exit functions Will Deacon
2010-08-29 18:52 ` [PATCH 3/3] x86: oprofile: fix oprofile_arch_init behaviour on failure Will Deacon
2010-08-30 9:09 ` Robert Richter
2010-08-31 8:54 ` Will Deacon
2010-08-31 9:05 ` Robert Richter
2010-08-31 9:31 ` Will Deacon
2010-08-31 9:47 ` Robert Richter
2010-08-31 10:30 ` [PATCH] oprofile, x86: fix init_sysfs error handling Robert Richter
2010-09-01 9:51 ` Ingo Molnar
2010-09-01 13:07 ` Robert Richter
2010-08-31 11:01 ` Robert Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831110152.GD22783@erda.amd.com \
--to=robert.richter@amd$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox