public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: broonie@opensource•wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mmc: move regulator handling to core
Date: Tue, 31 Aug 2010 12:07:58 +0100	[thread overview]
Message-ID: <20100831110758.GD20849@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <AANLkTim+cOSt=kjXXh_w+b4mzCiZN76HQ3az7SJKmOxR@mail.gmail.com>

On Sun, Aug 29, 2010 at 05:30:48PM +0200, Linus Walleij wrote:
> 2010/8/29 Mark Brown <broonie@opensource•wolfsonmicro.com>:

> > This seems like the wrong approach; if there's a problem it'd seem much
> > better to fix the core code that everything is sharing rather than
> > factor it out - the location of the code is orthogonal to its
> > helpfulness.

> I actually did not move the essential regulator bits out just enable/disable,
> so that these were in the sites where the regulators were actually
> enabled/disabled in respective driver. That makes the internal
> regulator reference count do the trick.

I'm not sure what "the sites where the regulators were actually
enabled/disabled in respective driver" are but my understanding was that
there's a bit of an issue here in that the MMC core does not guarantee
balanced enable/disable calls.

  reply	other threads:[~2010-08-31 11:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03 12:46 [PATCH] mmc: move regulator handling to core Daniel Mack
2009-12-03 13:06 ` Mark Brown
2009-12-03 13:14   ` Daniel Mack
2009-12-03 13:22     ` Mark Brown
2009-12-03 13:32       ` Daniel Mack
2009-12-03 13:40         ` Mark Brown
2009-12-03 13:43           ` Daniel Mack
2009-12-03 14:58       ` Russell King - ARM Linux
2009-12-03 15:09         ` Mark Brown
2009-12-03 14:27 ` Adrian Hunter
2009-12-03 19:20   ` Daniel Mack
2009-12-03 20:12     ` Adrian Hunter
2009-12-04 11:58       ` Daniel Mack
2009-12-12  0:58         ` Daniel Mack
2009-12-14 17:43           ` Madhusudhan
2009-12-15  5:44         ` David Brownell
2010-08-27 19:03 ` Chris Ball
2010-08-28 14:48   ` Linus Walleij
2010-08-29 13:27     ` Mark Brown
2010-08-29 15:30       ` Linus Walleij
2010-08-31 11:07         ` Mark Brown [this message]
2010-08-31 12:15           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100831110758.GD20849@rakim.wolfsonmicro.main \
    --to=broonie@opensource$(echo .)wolfsonmicro.com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox