public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: cjb@laptop•org (Chris Ball)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V8] mmc : Add i.MX21 support to mxcmmc driver
Date: Tue, 14 Sep 2010 04:03:20 +0100	[thread overview]
Message-ID: <20100914030318.GA10782@void.printf.net> (raw)
In-Reply-To: <20100909220110.12456.14417.stgit@srv002.fuzzey.net>

Hi Pavel, Sascha, 

On Fri, Sep 10, 2010 at 12:02:44AM +0200, Martin Fuzzey wrote:
> Even though the i.MX21 SDHC module has the same revision number as the i.MX27
> one there are a few differences!!
>         Some interrupt enables are inverted.
>         FIFO is only 16 bits wide.
>         The argument is written to 2x16bit registers (vs 1x32).
>         Interrupts must be acknowledged via the INT_CNTR register.
>         Card clock must be enabled for each request.
> 	For writes DMA must be enabled on command response not before.
> 
> Signed-off-by: Martin Fuzzey <mfuzzey@gmail•com>
> 
> ---
> Changes from V7 (February 2010):
> Rebased to 2.6.36-rc3
> 
> arch/arm/mach-imx/clock-imx21.c |    4 +
> drivers/mmc/host/mxcmmc.c       |  153 ++++++++++++++++++++++++++++++---------
> 2 files changed, 120 insertions(+), 37 deletions(-)

Any feedback on this patch from Martin?  

https://patchwork.kernel.org/patch/178242/

Thanks,

-- 
Chris Ball   <cjb@laptop•org>   <http://printf.net/>
One Laptop Per Child

next prev parent reply	other threads:[~2010-09-14  3:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-09 22:02 [PATCH V8] mmc : Add i.MX21 support to mxcmmc driver Martin Fuzzey
2010-09-14  3:03 ` Chris Ball [this message]
2010-09-16 11:07 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100914030318.GA10782@void.printf.net \
    --to=cjb@laptop$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox