From: broonie@opensource•wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4] ux500: add ab8500-regulators machine specific data
Date: Tue, 14 Sep 2010 09:05:17 +0100 [thread overview]
Message-ID: <20100914080517.GB423@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1284375772-22589-1-git-send-email-sundar.iyer@stericsson.com>
On Mon, Sep 13, 2010 at 04:32:52PM +0530, Sundar Iyer wrote:
> + .constraints = {
> + .name = "ab8500-vaux1",
> + .min_uV = AB8500_VAUXN_LDO_MIN_VOLTAGE,
> + .max_uV = AB8500_VAUXN_LDO_MAX_VOLTAGE,
> + .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE|
> + REGULATOR_CHANGE_STATUS,
As I keep pointing out this looks a bit odd since there are no consumers
set up on the regulator and you've got a large number of regulators with
this same set of constraints. However, this won't cause a problem
without any consumers so this should be OK.
prev parent reply other threads:[~2010-09-14 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 11:02 [PATCH v4] ux500: add ab8500-regulators machine specific data Sundar Iyer
2010-09-14 8:05 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914080517.GB423@opensource.wolfsonmicro.com \
--to=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox