From: daniel@caiaq•de (Daniel Mack)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH/RFC] i.MX31 and i.MX35 : fix errate TLSbo65953 and ENGcm09472
Date: Wed, 6 Oct 2010 08:35:25 +0200 [thread overview]
Message-ID: <20101006063525.GS7159@buzzloop.caiaq.de> (raw)
In-Reply-To: <20101005162920.GT11737@pengutronix.de>
On Tue, Oct 05, 2010 at 06:29:20PM +0200, Uwe Kleine-K?nig wrote:
> On Tue, Oct 05, 2010 at 11:25:39AM +0200, Eric B?nard wrote:
> > +#else
> > #ifdef CONFIG_ARCH_MXC91231
> > if (cpu_is_mxc91231()) {
> > /* Need this to set DSM low-power mode */
> > mxc91231_prepare_idle();
> > }
> > #endif
> > -
> > cpu_do_idle();
> > +#endif
> No. When we start to have multi-soc support for imx and a kernel for
> both mx35 and mxc91231 is compiled mxc91231_prepare_idle isn't called
> anymore for mxc91231. Ah, and cpu_do_idle isn't called anymore at all.
>
> This needs to read:
>
> #if defined (CONFIG_ARCH_MX31) || defined (CONFIG_ARCH_MX35)
> if (cpu_is_mx31() || cpu_is_mx35()) {
> unsigned long reg = 0;
> __asm__ __volatile__(...);
A "return" statement here would save you the else branch and
subsequently, one indentation level, right?
Also, I wonder whether the check for CONFIG_ARCH_MX3[15] is actually
needed at all, as cpu_is_mx3x() will default to 0 at compile time in
case those #defines are not set.
> } else
> #endif
> {
>
> #ifdef CONFIG_ARCH_MXC91231
> if (cpu_is_mxc91231()) {
> /* Need this to set DSM low-power mode */
> mxc91231_prepare_idle();
> }
> #endif
In this case, though, they seem mandatory due to the symbol
mxc91231_prepare_idle would be undefined otherwise.
Daniel
next prev parent reply other threads:[~2010-10-06 6:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 13:55 I.MX35 GPIO IRQ + Preempt -> Oops Eric Bénard
2010-10-03 11:41 ` Russell King - ARM Linux
2010-10-03 15:25 ` Eric Bénard
2010-10-03 16:20 ` Russell King - ARM Linux
2010-10-03 17:15 ` Eric Bénard
2010-10-04 7:39 ` Uwe Kleine-König
2010-10-04 8:08 ` Eric Bénard
2010-10-04 12:07 ` Eric Bénard
2010-10-05 5:06 ` Marc Reilly
2010-10-05 7:28 ` Eric Bénard
2010-10-05 9:13 ` Eric Bénard
2010-10-05 9:25 ` [PATCH/RFC] i.MX31 and i.MX35 : fix errate TLSbo65953 and ENGcm09472 Eric Bénard
2010-10-05 9:45 ` Sascha Hauer
2010-10-05 12:00 ` [PATCH v2] " Eric Bénard
2010-10-05 18:33 ` Uwe Kleine-König
2010-10-05 19:31 ` Eric Bénard
2010-10-05 19:46 ` Uwe Kleine-König
2010-10-05 20:00 ` Eric Bénard
2010-10-05 20:04 ` Uwe Kleine-König
2010-10-05 20:27 ` Eric Bénard
2010-10-06 2:28 ` Nicolas Pitre
2010-10-06 11:09 ` Eric Bénard
2010-10-08 8:49 ` [PATCH v3] " Eric Bénard
2010-10-07 7:27 ` [PATCH v2] " Russell King - ARM Linux
2010-10-05 16:29 ` [PATCH/RFC] " Uwe Kleine-König
2010-10-05 16:48 ` Eric Bénard
2010-10-05 17:40 ` Uwe Kleine-König
2010-10-06 6:35 ` Daniel Mack [this message]
2010-10-06 7:03 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006063525.GS7159@buzzloop.caiaq.de \
--to=daniel@caiaq$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox