public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] serial: DCC(JTAG) serial and console emulation support
Date: Thu, 7 Oct 2010 14:27:07 -0700	[thread overview]
Message-ID: <20101007212707.GI7558@atomide.com> (raw)
In-Reply-To: <1286305668-19987-1-git-send-email-dwalker@codeaurora.org>

Hi,

* Daniel Walker <dwalker@codeaurora•org> [101005 11:59]:
> +#if !defined(CONFIG_CPU_V7)
> +static inline char
> +__dcc_getchar(void)
> +{
> +	char __c;
> +
> +	asm("mrc p14, 0, %0, c0, c5, 0	@ read comms data reg"
> +		: "=r" (__c) : : "cc");
> +
> +	return __c;
> +}
> +#else
> +static inline char
> +__dcc_getchar(void)
> +{
> +	char __c;
> +
> +	asm(
> +	"get_wait:	mrc p14, 0, pc, c0, c1, 0                   \n\
> +			bne get_wait                                    \n\
> +			mrc p14, 0, %0, c0, c5, 0	@ read comms data reg"
> +		: "=r" (__c) : : "cc");
> +
> +	return __c;
> +}
> +#endif
> +
> +#if !defined(CONFIG_CPU_V7)
> +static inline void
> +__dcc_putchar(char c)
> +{
> +	asm("mcr p14, 0, %0, c0, c5, 0	@ write a char"
> +		: /* no output register */
> +		: "r" (c) : "cc");
> +}
> +#else
> +static inline void
> +__dcc_putchar(char c)
> +{
> +	asm(
> +	"put_wait:	mrc p14, 0, pc, c0, c1, 0                   \n\
> +			bcs put_wait                                \n\
> +			mcr p14, 0, %0, c0, c5, 0                   "
> +	: : "r" (c) : "cc");
> +}
> +#endif

Can you please pass the read and write functions to the driver
in platform_data? We are already booting kernels with both
ARMv6 and 7 compiled in.

Also, as it's a driver, other architectures may want to use it too.

Regards,

Tony

  parent reply	other threads:[~2010-10-07 21:27 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05 19:07 [PATCH] serial: DCC(JTAG) serial and console emulation support Daniel Walker
2010-10-06  2:55 ` Nicolas Pitre
2010-10-06 13:48   ` Daniel Walker
2010-10-06 14:22     ` Nicolas Pitre
2010-10-06 14:49       ` Daniel Walker
2010-10-06 15:21         ` Nicolas Pitre
2010-10-06 15:33           ` Daniel Walker
2010-10-06 15:47             ` Nicolas Pitre
2010-10-06 15:54               ` Daniel Walker
2010-10-06 16:22                 ` Nicolas Pitre
2010-10-06 16:40                   ` Daniel Walker
2010-10-06 17:02                     ` Nicolas Pitre
2010-10-06 17:07                       ` Daniel Walker
2010-10-07 21:27 ` Tony Lindgren [this message]
2010-10-07 21:58   ` Daniel Walker
2010-10-08  1:28     ` Nicolas Pitre
2010-10-08 20:35       ` Tony Lindgren
2010-10-08 20:59         ` Tony Lindgren
2010-10-08 21:27         ` Nicolas Pitre
2010-10-08 20:36     ` Tony Lindgren
2010-10-08  1:25   ` Nicolas Pitre
2010-10-08 20:32     ` Tony Lindgren
2010-10-08 20:58       ` Tony Lindgren
2010-10-08 21:28         ` Nicolas Pitre
2010-10-08 21:25       ` Nicolas Pitre
2010-10-08 21:49         ` Tony Lindgren
2010-10-09  0:57           ` Nicolas Pitre
2010-10-13 15:21 ` Arnd Bergmann
2010-10-13 16:17   ` Daniel Walker
2010-10-13 17:44     ` Arnd Bergmann
2010-10-13 18:08       ` Daniel Walker
2010-10-13 19:45         ` Arnd Bergmann
2010-10-13 19:52           ` Daniel Walker
2010-10-13 20:10             ` Arnd Bergmann
2010-10-13 20:24               ` Daniel Walker
2010-10-13 20:44                 ` Nicolas Pitre
2010-10-13 20:49                   ` Daniel Walker
2010-10-13 22:51                     ` Nicolas Pitre
2010-10-13 23:26                       ` Russell King - ARM Linux
2010-10-13 23:41                         ` Nicolas Pitre
2010-10-13 19:55         ` Nicolas Pitre
2010-10-13 20:00           ` Daniel Walker
2010-10-13 20:27             ` Nicolas Pitre
2010-10-13 20:47               ` Daniel Walker
2010-10-13 22:05                 ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101007212707.GI7558@atomide.com \
    --to=tony@atomide$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox