public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: cjb@laptop•org (Chris Ball)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
Date: Fri, 22 Oct 2010 12:04:57 +0100	[thread overview]
Message-ID: <20101022110457.GA14136@void.printf.net> (raw)
In-Reply-To: <20101022095814.GA13073@void.printf.net>

Hi,

On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote:
[...]
> +#ifdef CONFIG_PM
> +static int sdhci_pxa_suspend(struct platform_device *dev)
> +{
> +	struct sdhci_host *host = platform_get_drvdata(to_platform_device(dev));
> +
> +	return sdhci_suspend_host(host, state);
> +}
> +
> +static int sdhci_pxa_resume(struct platform_device *dev)
> +{

These prototypes are not correct, leading to:

  CC [M]  drivers/mmc/host/sdhci-pxa.o
drivers/mmc/host/sdhci-pxa.c: In function ?sdhci_pxa_suspend?:
drivers/mmc/host/sdhci-pxa.c:205: warning: initialization from incompatible pointer type
drivers/mmc/host/sdhci-pxa.c:207: error: ?state? undeclared (first use in this function)
drivers/mmc/host/sdhci-pxa.c:207: error: (Each undeclared identifier is reported only once
drivers/mmc/host/sdhci-pxa.c:207: error: for each function it appears in.)
drivers/mmc/host/sdhci-pxa.c: In function ?sdhci_pxa_resume?:
drivers/mmc/host/sdhci-pxa.c:212: warning: initialization from incompatible pointer type
drivers/mmc/host/sdhci-pxa.c: At top level:
drivers/mmc/host/sdhci-pxa.c:222: warning: initialization from incompatible pointer type
drivers/mmc/host/sdhci-pxa.c:223: warning: initialization from incompatible pointer type

when compiled with CONFIG_PM=y.

-- 
Chris Ball   <cjb@laptop•org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2010-10-22 11:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTikivxhU6Lzxe0Xn9r9hOSPLwuySRkTdGif4F_xo@mail.gmail.com>
     [not found] ` <20101021141302.GA11912@void.printf.net>
2010-10-21 14:52   ` [PATCH V3 1/1]MMC: add support of sdhci-pxa driver Chris Ball
2010-10-22  0:20     ` Marek Vasut
2010-10-22  0:27       ` Chris Ball
2010-10-22  8:44     ` Haojian Zhuang
2010-10-22  9:58       ` Chris Ball
2010-10-22 11:04         ` Chris Ball [this message]
2010-10-22 14:09           ` zhangfei gao
2010-10-23 14:24             ` Marek Vasut
2010-10-23 16:47               ` zhangfei gao
2010-10-23 17:50                 ` Marek Vasut
2010-10-24  3:26                   ` zhangfei gao
2010-10-24  4:02                     ` Marek Vasut
2010-10-25  5:48                       ` zhangfei gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101022110457.GA14136@void.printf.net \
    --to=cjb@laptop$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox