From: simon@sequanux•org (Simon Guinot)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] genirq: replace irq_gc_ack() with {set,clr}_bit variants
Date: Wed, 6 Jul 2011 15:31:28 +0000 [thread overview]
Message-ID: <20110706153128.GA22857@kw.sim.vm.gnt> (raw)
In-Reply-To: <1309789999-2293-1-git-send-email-simon@sequanux.org>
Hi Thomas,
On Mon, Jul 04, 2011 at 04:33:19PM +0200, Simon Guinot wrote:
> From: Simon Guinot <sguinot@lacie•com>
>
> Depending on the device, interrupts acknowledgement is done by setting
> or by clearing a dedicated register. Replace irq_gc_ack() with some
> {set,clr}_bit variants allows to handle both cases.
>
> Note that this patch affects the following SoCs: Davinci, Samsung and
> Orion. Except for this last, the change is minor: irq_gc_ack() is just
> renamed into irq_gc_ack_set_bit().
>
> For the Orion SoCs, the edge GPIO interrupts support is currently
> broken. irq_gc_ack() try to acknowledge a such interrupt by setting
> the corresponding cause register bit. The Orion GPIO device expect the
> opposite. To fix this issue, the irq_gc_ack_clr_bit() variant is used.
>
> Tested on Network Space v2.
>
> Reported-by: Joey Oravec <joravec@drewtech•com>
> Signed-off-by: Simon Guinot <sguinot@lacie•com>
> ---
> Changes for v2: update patch description (mention the affected SoCs).
>
> arch/arm/mach-davinci/irq.c | 2 +-
> arch/arm/plat-orion/gpio.c | 2 +-
> arch/arm/plat-s5p/irq-gpioint.c | 2 +-
> arch/arm/plat-samsung/irq-uart.c | 2 +-
> include/linux/irq.h | 3 ++-
> kernel/irq/generic-chip.c | 18 ++++++++++++++++--
> 6 files changed, 22 insertions(+), 7 deletions(-)
Please, apply this patch.
Regards,
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110706/dd8a0d68/attachment.sig>
next prev parent reply other threads:[~2011-07-06 15:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 19:14 plat-orion multi purpose pins problem for mv78200 Joey Oravec
2011-07-01 21:56 ` Joey Oravec
2011-07-02 12:23 ` Simon Guinot
2011-07-03 12:46 ` saeed bishara
2011-07-04 14:33 ` [PATCH v2] genirq: replace irq_gc_ack() with {set,clr}_bit variants Simon Guinot
2011-07-04 14:48 ` [PATCH v2] genirq: replace irq_gc_ack() with {set, clr}_bit variants Nicolas Pitre
2011-07-16 3:39 ` Kukjin Kim
2011-07-06 15:31 ` Simon Guinot [this message]
2011-07-05 15:37 ` plat-orion multi purpose pins problem for mv78200 Joey Oravec
2011-07-06 16:18 ` Simon Guinot
2011-07-06 16:32 ` saeed bishara
2011-07-06 18:49 ` Joey Oravec
2011-07-07 6:40 ` saeed bishara
2011-07-07 13:49 ` Joey Oravec
2011-07-10 13:21 ` saeed bishara
2011-07-12 13:36 ` Joey Oravec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706153128.GA22857@kw.sim.vm.gnt \
--to=simon@sequanux$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox