From: heiko@sntech•de (Heiko Stübner)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code
Date: Tue, 23 Aug 2011 22:28:49 +0200 [thread overview]
Message-ID: <201108232228.49647.heiko@sntech.de> (raw)
In-Reply-To: <06c001cc6146$b9f30be0$2dd923a0$%kim@samsung.com>
Am Dienstag 23 August 2011, 05:42:47 schrieb Kukjin Kim:
> Heiko St?bner wrote:
> > Am Sonntag 21 August 2011, 19:13:32 schrieb Russell King - ARM Linux:
> > > On Sat, Aug 20, 2011 at 06:01:29PM +0200, Heiko St?bner wrote:
> > > > +/* i2s-ref
> > > > + *
> > > > + * i2s bus reference clock, selectable from external, esysclk or
>
> epllref
>
> > > > + *
> > > > + * Note, this used to be two clocks, but was compressed into one.
> > > > +*/
> > > > +
> > > > +struct clk *clk_i2s_srclist[] = {
> > > > + [0] = &clk_i2s_eplldiv.clk,
> > > > + [1] = &clk_i2s_ext,
> > > > + [2] = &clk_epllref.clk,
> > > > + [3] = &clk_epllref.clk,
> > > > +};
> > >
> > > Is there any reason not to make this static (have you run your patch
> > > through checkpatch.pl ?)
> >
> > Yep I did run all of them through checkpatch (after beeing scolded last
>
> time)
>
> > and it didn't report anything.
>
> Hmm...as a note, happened following with checkpatch.pl :(
>
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #35: FILE: arch/arm/mach-s3c2416/clock.c:57:
> + .sources = (struct clk *[]) {
> ^
>
> total: 1 errors, 0 warnings, 38 lines checked
>
> PATCH 34 S3C2416 Add HSSPI clock sourced from EPLL.txt has style problems,
> please review.
will do.
Today I also saw, that my definition of the hsspi pclk would have caused a
conflict with the hsspi sclk definition of s3c2443.
So, as nobody uses the s3c2443's hsspi controller yet, I would also rename it
to hsspi-if with the next patch iteration.
Heiko
next prev parent reply other threads:[~2011-08-23 20:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 15:57 [PATCH 0/4] S3C2416: Enable IIS and HSSPI clocks Heiko Stübner
2011-08-20 16:01 ` [PATCH 1/4] S3C2443: Move i2s clock definitions to common code Heiko Stübner
2011-08-21 17:13 ` Russell King - ARM Linux
2011-08-21 17:25 ` Heiko Stübner
2011-08-21 20:26 ` Marek Vasut
2011-08-21 21:11 ` Heiko Stübner
2011-08-23 3:42 ` Kukjin Kim
2011-08-23 20:28 ` Heiko Stübner [this message]
2011-08-20 16:02 ` [PATCH 2/4] S3C2443: Define constant for HSSPI pclk Heiko Stübner
2011-08-20 16:03 ` [PATCH 3/4] S3C2416: Add HSSPI clock sourced from EPLL Heiko Stübner
2011-08-20 16:03 ` [PATCH 4/4] S3C2443: Add hsspi-clock from pclk Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108232228.49647.heiko@sntech.de \
--to=heiko@sntech$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox