From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/6] ARM: add Highbank core platform support
Date: Thu, 25 Aug 2011 18:02:29 +0200 [thread overview]
Message-ID: <201108251802.29251.arnd@arndb.de> (raw)
In-Reply-To: <4E5000A1.8060609@gmail.com>
On Saturday 20 August 2011, Rob Herring wrote:
> >> +#ifndef _MACH_HIGHBANK__SYSREGS_H_
> >> +#define _MACH_HIGHBANK__SYSREGS_H_
> >> +
> >> +extern void __iomem *sregs_base;
> >> +
> >> +#define HB_SREG_A9_PWR_REQ 0xf00
> >> +#define HB_SREG_A9_BOOT_STAT 0xf04
> >> +#define HB_SREG_A9_BOOT_DATA 0xf08
> >> +
> >> +#define HB_PWR_SUSPEND 0
> >> +#define HB_PWR_SOFT_RESET 1
> >> +#define HB_PWR_HARD_RESET 2
> >> +#define HB_PWR_SHUTDOWN 3
> >> +
> >> +#endif
> >
> > Do these really need to be global?
> >
> > I think it's better to put the base address and register definitions into a
> > single file and export functions to be used from elsewhere.
>
> Yes, sregs are a random collection of functions, so it's going to be a
> mixture of various users. Just HB_PWR_* alone are in 2 or 3 different
> places.
Sorry, I'm not following.
Do you mean 'yes, they need to be global' or 'yes, it's better to export
the functions'?
Arnd
next prev parent reply other threads:[~2011-08-25 16:02 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 20:34 [PATCH 0/6] Initial Calxeda Highbank support Rob Herring
2011-08-16 20:34 ` [PATCH 1/6] ARM: highbank: add devicetree source Rob Herring
2011-08-17 7:27 ` Shawn Guo
2011-08-17 13:49 ` Rob Herring
2011-08-17 14:51 ` Shawn Guo
2011-08-20 18:32 ` Rob Herring
2011-08-17 17:52 ` Will Deacon
2011-08-20 18:29 ` Rob Herring
2011-08-17 9:27 ` Mark Rutland
[not found] ` <4e4b8979.533fd80a.2ff3.1626SMTPIN_ADDED@mx.google.com>
2011-08-17 14:08 ` Rob Herring
2011-08-17 14:34 ` Will Deacon
2011-08-20 9:51 ` Shawn Guo
2011-08-20 18:19 ` Rob Herring
2011-08-16 20:34 ` [PATCH 2/6] ARM: add Highbank core platform support Rob Herring
2011-08-16 22:19 ` Jamie Iles
2011-08-25 2:19 ` Rob Herring
2011-08-17 7:43 ` Russell King - ARM Linux
2011-08-18 15:34 ` Arnd Bergmann
2011-08-18 15:40 ` Russell King - ARM Linux
2011-08-19 14:11 ` Arnd Bergmann
2011-08-20 19:24 ` Rob Herring
2011-08-20 23:05 ` Russell King - ARM Linux
2011-08-20 18:44 ` Rob Herring
2011-08-25 2:45 ` Rob Herring
2011-08-25 4:03 ` Shawn Guo
2011-08-25 15:59 ` Arnd Bergmann
2011-08-25 16:02 ` Arnd Bergmann [this message]
2011-08-25 18:03 ` Rob Herring
2011-08-25 21:44 ` Arnd Bergmann
2011-08-19 6:43 ` Shawn Guo
2011-08-19 7:17 ` Shawn Guo
2011-08-20 18:16 ` Rob Herring
2011-08-19 8:56 ` Dave Martin
2011-08-19 13:45 ` Arnd Bergmann
2011-08-20 14:48 ` Shawn Guo
2011-08-20 18:21 ` Rob Herring
2011-08-20 15:54 ` Shawn Guo
2011-08-20 16:10 ` Shawn Guo
2011-08-20 18:22 ` Rob Herring
2011-08-22 5:55 ` Shawn Guo
2011-08-22 10:01 ` Jamie Iles
2011-08-23 3:33 ` Shawn Guo
2011-08-22 8:35 ` Shawn Guo
2011-08-22 9:15 ` Shawn Guo
2011-08-22 13:23 ` Rob Herring
2011-08-16 20:34 ` [PATCH 3/6] MAINTAINERS: add Calxeda Highbank ARM platform Rob Herring
2011-08-16 20:34 ` [PATCH 4/6] ARM: highbank: add SMP support Rob Herring
2011-08-17 7:37 ` Russell King - ARM Linux
2011-08-17 14:01 ` Rob Herring
2011-08-17 18:52 ` Russell King - ARM Linux
2011-08-16 20:34 ` [PATCH 5/6] ARM: highbank: Add cpu hotplug support Rob Herring
2011-08-16 20:34 ` [PATCH 6/6] ARM: highbank: add suspend support Rob Herring
2011-08-25 1:17 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108251802.29251.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox