From: ben@decadent•org.uk (Ben Hutchings)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm: ixp4xx, u300: Select ARCH_REQUIRE_GPIOLIB, not GENERIC_GPIO
Date: Mon, 5 Sep 2011 17:22:26 +0100 [thread overview]
Message-ID: <20110905162226.GI2802@decadent.org.uk> (raw)
In-Reply-To: <CACRpkdaACXxzhQ4m3+4tzTGrXubFF6jPkO9uG0kqVzvm+ORYwQ@mail.gmail.com>
On Mon, Sep 05, 2011 at 02:41:30PM +0200, Linus Walleij wrote:
> On Mon, Sep 5, 2011 at 5:12 AM, Ben Hutchings <ben@decadent•org.uk> wrote:
>
> > @@ -830,7 +830,7 @@ config ARCH_U300
> > ? ? ? ?select GENERIC_CLOCKEVENTS
> > ? ? ? ?select CLKDEV_LOOKUP
> > ? ? ? ?select HAVE_MACH_CLKDEV
> > - ? ? ? select GENERIC_GPIO
> > + ? ? ? select ARCH_REQUIRE_GPIOLIB
> > ? ? ? ?help
> > ? ? ? ? ?Support for ST-Ericsson U300 series mobile platforms.
>
> Please don't do that, it really is no gpiolib implementation.
>
> In the archives you can find patches I already submitted switching
> the U300 GPIO over to use gpiolib.
[...]
OK. But it doesn't seem to work without gpiolib either:
CC [M] drivers/input/touchscreen/ads7846.o
drivers/input/touchscreen/ads7846.c: In function 'ads7846_setup_pendown':
drivers/input/touchscreen/ads7846.c:970:3: error: implicit declaration of function 'gpio_request_one'
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
next prev parent reply other threads:[~2011-09-05 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 3:12 [PATCH] arm: ixp4xx, u300: Select ARCH_REQUIRE_GPIOLIB, not GENERIC_GPIO Ben Hutchings
2011-09-05 6:54 ` Arnaud Patard (Rtp)
2011-09-05 10:41 ` Russell King - ARM Linux
2011-09-05 12:18 ` Arnaud Patard (Rtp)
2011-09-05 12:49 ` [RFC/PATCH] ARM: ixp4xx gpiolib support Imre Kaloz
2011-09-06 6:49 ` Arnaud Patard (Rtp)
2011-09-06 7:30 ` Uwe Kleine-König
2011-09-05 12:41 ` [PATCH] arm: ixp4xx, u300: Select ARCH_REQUIRE_GPIOLIB, not GENERIC_GPIO Linus Walleij
2011-09-05 16:22 ` Ben Hutchings [this message]
2011-09-06 7:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110905162226.GI2802@decadent.org.uk \
--to=ben@decadent$(echo .)org.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox