From: dave.martin@linaro•org (Dave Martin)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH 2/3] ARM: iwmmxt: Port problematic iwmmxt support code to v7/Thumb-2
Date: Thu, 8 Sep 2011 09:58:00 +0100 [thread overview]
Message-ID: <20110908085800.GB2070@arm.com> (raw)
In-Reply-To: <1790084.iooACCopcX@wuerfel>
On Wed, Sep 07, 2011 at 10:35:46PM +0200, Arnd Bergmann wrote:
> On Wednesday 07 September 2011 09:13:38 Eric Miao wrote:
> > >
> > > +/*
> > > + * When enough people have binutils which support -march=...+iwmmxt, this
> > > + * should change to #if __LINUX_ARM_ARCH__ < 7.
> > > + */
> > > +#ifndef CONFIG_THUMB2_KERNEL
> > > mrc p15, 0, r1, c2, c0, 0
> > > sub pc, lr, r1, lsr #32 @ cpwait and return
> > > +#else
> > > + isb @ ISB needed instead on ARMv7
> > > + mov pc, lr
> > > +#endif
> >
> > Or maybe using ARM() and THUMB() will be a better fit here?
>
> I think it would be logical to use XSC() and PJ4() instead, as those are used
> elsehere in this file. However, that doesn't work with the only binutils.
I take pj4 and older platforms can never be built in the same kernel?
Otherwise, this approach is totally broken anyway-- we'll generate code
which won't run on some of the kernel's supported platforms.
> If the !THUMB code above is actually correct for v7 in ARM mode (i.e. it performs
> the equivalent of an ISB), then I think we should leave it.
With the proposed change to use cc-option in the Makefile,
we have the option of using the v7 code whenever binutils supports
it, and printing a warning otherwise.
> It does look like it's whitespace broken though.
I'll double-check that.
Cheers
---Dave
next prev parent reply other threads:[~2011-09-08 8:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 15:59 [RFC PATCH 0/3] ARM: iwmmxt/pj4 fixes for v7/Thumb-2 Dave Martin
2011-09-07 15:59 ` [RFC PATCH 1/3] ARM: iwmmxt: Fix Makefile rules for building iwmmxt for Thumb-2 Dave Martin
2011-09-07 16:10 ` Eric Miao
2011-09-07 17:18 ` Nicolas Pitre
2011-09-07 20:32 ` Arnd Bergmann
2011-09-08 8:53 ` Dave Martin
2011-09-07 15:59 ` [RFC PATCH 2/3] ARM: iwmmxt: Port problematic iwmmxt support code to v7/Thumb-2 Dave Martin
2011-09-07 16:13 ` Eric Miao
2011-09-07 20:35 ` Arnd Bergmann
2011-09-08 8:58 ` Dave Martin [this message]
2011-09-08 9:01 ` Russell King - ARM Linux
2011-09-08 11:33 ` Dave Martin
2011-09-08 14:40 ` Arnd Bergmann
2011-09-07 15:59 ` [RFC PATCH 3/3] ARM: pxa/pj4: Port problematic pj4 " Dave Martin
2011-09-07 16:18 ` Eric Miao
2011-09-07 20:27 ` Arnd Bergmann
2011-09-08 8:58 ` Haojian Zhuang
2011-09-08 11:10 ` Sergei Shtylyov
2011-09-08 11:35 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908085800.GB2070@arm.com \
--to=dave.martin@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox