From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init
Date: Fri, 30 Sep 2011 11:01:22 -0700 [thread overview]
Message-ID: <20110930180121.GK6324@atomide.com> (raw)
In-Reply-To: <20110929070849.GA27987@legolas.emea.dhcp.ti.com>
* Felipe Balbi <balbi@ti•com> [110928 23:35]:
> On Tue, Sep 20, 2011 at 04:50:29PM +0800, Axel Lin wrote:
> > Current code calls omap4430_phy_init() twice in usb_musb_init().
> > Calling omap4430_phy_init() once is enough.
> > This patch removes the first omap4430_phy_init() call, which using an
> > uninitialized pointer as parameter.
> >
> > This patch elimates below build warning:
> > arch/arm/mach-omap2/usb-musb.c: In function 'usb_musb_init':
> > arch/arm/mach-omap2/usb-musb.c:141: warning: 'dev' may be used uninitialized in this function
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail•com>
>
> Acked-by: Felipe Balbi <balbi@ti•com>
Thanks, applying into fixes.
Tony
>
> > ---
> > arch/arm/mach-omap2/usb-musb.c | 3 ---
> > 1 files changed, 0 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > index a65145b..19e4dac 100644
> > --- a/arch/arm/mach-omap2/usb-musb.c
> > +++ b/arch/arm/mach-omap2/usb-musb.c
> > @@ -137,9 +137,6 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
> > musb_plat.mode = board_data->mode;
> > musb_plat.extvbus = board_data->extvbus;
> >
> > - if (cpu_is_omap44xx())
> > - omap4430_phy_init(dev);
> > -
> > if (cpu_is_omap3517() || cpu_is_omap3505()) {
> > oh_name = "am35x_otg_hs";
> > name = "musb-am35x";
> > --
> > 1.7.4.1
> >
> >
> >
>
> --
> balbi
next prev parent reply other threads:[~2011-09-30 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 8:50 [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init Axel Lin
2011-09-20 14:27 ` Bjarne Steinsbo
2011-09-29 7:08 ` Felipe Balbi
2011-09-30 18:01 ` Tony Lindgren [this message]
2011-10-03 18:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930180121.GK6324@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox