From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 04/30] ARM: omap: add missing __devexit_p() annotations
Date: Mon, 3 Oct 2011 10:48:48 -0700 [thread overview]
Message-ID: <20111003174844.GQ6324@atomide.com> (raw)
In-Reply-To: <CAFULf_wevZxWW1RW+r-18R_8=ry2kD6_i5L9NfPd9t8afm5Cog@mail.gmail.com>
* Bjarne Steinsbo <bsteinsbo@gmail•com> [111002 08:22]:
> Arnd,
>
> Ref http://www.spinics.net/lists/linux-omap/msg57274.html
>
> Don't get me wrong. This is not about you "stealing" my patch, or
> anything like that. But look also at thread starting at
> http://www.spinics.net/lists/linux-omap/msg57667.html Also a patch
> that I have posted previously. Something is not right with the
> workflow when bugs are identified, patches are submitted, then
> ignored, only for someone else to fix the same bug. Enough said.
Arnd, I suggest using Bjarne's earlier patch here:
Acked-by: Tony Lindgren <tony@atomide•com>
> On Sun, Oct 2, 2011 at 4:45 PM, Arnd Bergmann <arnd@arndb•de> wrote:
> > Drivers that refer to a __devexit function in an operations
> > structure need to annotate that pointer with __devexit_p so
> > replace it with a NULL pointer when the section gets discarded.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> > ---
> > ?arch/arm/mach-omap2/smartreflex.c | ? ?2 +-
> > ?arch/arm/plat-omap/dma.c ? ? ? ? ?| ? ?2 +-
> > ?2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> > index 34c01a7..67bc6ce 100644
> > --- a/arch/arm/mach-omap2/smartreflex.c
> > +++ b/arch/arm/mach-omap2/smartreflex.c
> > @@ -1002,7 +1002,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev)
> > ?}
> >
> > ?static struct platform_driver smartreflex_driver = {
> > - ? ? ? .remove ? ? ? ? = omap_sr_remove,
> > + ? ? ? .remove ? ? ? ? = __devexit_p(omap_sr_remove),
> > ? ? ? ?.driver ? ? ? ? = {
> > ? ? ? ? ? ? ? ?.name ? = "smartreflex",
> > ? ? ? ?},
> > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> > index c22217c..f7150ba 100644
> > --- a/arch/arm/plat-omap/dma.c
> > +++ b/arch/arm/plat-omap/dma.c
> > @@ -2105,7 +2105,7 @@ static int __devexit omap_system_dma_remove(struct platform_device *pdev)
> >
> > ?static struct platform_driver omap_system_dma_driver = {
> > ? ? ? ?.probe ? ? ? ? ?= omap_system_dma_probe,
> > - ? ? ? .remove ? ? ? ? = omap_system_dma_remove,
> > + ? ? ? .remove ? ? ? ? = __devexit_p(omap_system_dma_remove),
> > ? ? ? ?.driver ? ? ? ? = {
> > ? ? ? ? ? ? ? ?.name ? = "omap_dma_system"
> > ? ? ? ?},
> > --
> > 1.7.5.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at ?http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-10-03 17:48 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 14:45 [PATCH 00/30] ARM/omap: omap specific randconfig fixes Arnd Bergmann
2011-10-02 14:45 ` [PATCH 01/30] sound/omap: omap_mcpdm_remove cannot be __devexit Arnd Bergmann
2011-10-02 19:24 ` Mark Brown
2011-10-02 14:45 ` [PATCH 02/30] video/omap: fix dependencies Arnd Bergmann
2011-10-03 6:53 ` Tomi Valkeinen
2011-10-03 9:51 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 03/30] video/omap: fix build dependencies Arnd Bergmann
2011-10-03 6:59 ` Tomi Valkeinen
2011-10-03 9:51 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 04/30] ARM: omap: add missing __devexit_p() annotations Arnd Bergmann
2011-10-02 15:56 ` Bjarne Steinsbo
2011-10-02 16:09 ` Russell King - ARM Linux
2011-10-03 17:46 ` Tony Lindgren
2011-10-03 17:48 ` Tony Lindgren [this message]
2011-10-03 4:59 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 05/30] ARM: omap: enable building omap2 without omap2420/2430 Arnd Bergmann
2011-10-03 5:07 ` Santosh Shilimkar
2011-10-03 17:53 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 06/30] ARM: omap: fix build with CONFIG_I2C_OMAP disabled Arnd Bergmann
2011-10-03 5:06 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 07/30] ARM: omap: fix visibility of omap2_mbox_iva_priv Arnd Bergmann
2011-10-03 5:08 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 08/30] ARM: omap2+: fix building without i2c Arnd Bergmann
2011-10-03 1:31 ` Paul Walmsley
2011-10-03 9:49 ` Arnd Bergmann
2011-10-03 17:56 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 09/30] ARM: omap2: export functions used by nand driver Arnd Bergmann
2011-10-03 17:56 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 10/30] ARM: omap/iommu: always provide iommu debug code Arnd Bergmann
2011-10-02 16:34 ` Ohad Ben-Cohen
2011-10-02 18:01 ` Arnd Bergmann
2011-10-02 18:21 ` Ohad Ben-Cohen
2011-10-03 17:57 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 11/30] ARM: omap2/n8x0: work around modular omap mmc Arnd Bergmann
2011-10-02 15:53 ` Russell King - ARM Linux
2011-10-02 18:54 ` Arnd Bergmann
2011-10-03 18:03 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 12/30] ARM: omap4: always build omap_phy_internal Arnd Bergmann
2011-10-03 18:04 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 13/30] ARM: omap2+: fix omap_hdq_init compilation Arnd Bergmann
2011-10-03 5:11 ` Santosh Shilimkar
2011-10-03 18:06 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 14/30] ARM: omap2: irq.c is always needed Arnd Bergmann
2011-10-03 5:14 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method Arnd Bergmann
2011-10-02 16:14 ` Russell King - ARM Linux
2011-10-02 18:00 ` Arnd Bergmann
2011-10-02 18:56 ` Felipe Balbi
2011-10-02 19:44 ` Arnd Bergmann
2011-10-02 22:10 ` Felipe Balbi
2011-10-03 9:40 ` Arnd Bergmann
2011-10-03 10:07 ` Felipe Balbi
2011-10-10 6:10 ` Felipe Balbi
2011-10-02 14:45 ` [PATCH 16/30] usb/musb: HDRC depends on TWL4030_CORE for OMAP3/4 Arnd Bergmann
2011-10-02 18:59 ` Felipe Balbi
2011-10-02 14:45 ` [PATCH 17/30] usb/musb: allow building USB_MUSB_TUSB6010 as a module Arnd Bergmann
2011-10-03 18:14 ` Tony Lindgren
2011-10-10 6:10 ` Felipe Balbi
2011-10-02 14:45 ` [PATCH 18/30] omap-usb: automatically select MFD_OMAP_USB_HOST Arnd Bergmann
2011-10-04 11:00 ` Samuel Ortiz
2011-10-02 14:45 ` [PATCH 19/30] tty/serial/omap: console can only be built-in Arnd Bergmann
2011-10-03 4:53 ` Govindraj
2011-10-02 14:45 ` [PATCH 20/30] media/omap_vout: disable driver for now Arnd Bergmann
2011-10-03 6:09 ` Archit Taneja
2011-10-03 9:16 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 21/30] sound/soc/omap: limit to omap2plus Arnd Bergmann
2011-10-02 17:40 ` Jarkko Nikula
2011-10-02 18:03 ` Arnd Bergmann
2011-10-02 18:24 ` Jarkko Nikula
2011-10-02 18:30 ` Arnd Bergmann
2011-10-02 19:18 ` Mark Brown
2011-10-02 14:45 ` [PATCH 22/30] mfd: build twl6030 only on omap2 Arnd Bergmann
2011-10-04 10:47 ` Samuel Ortiz
2011-10-04 14:47 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 23/30] ARM: omap2: select twl4030 support on boards that need it Arnd Bergmann
2011-10-03 5:19 ` Santosh Shilimkar
2011-10-03 11:03 ` Arnd Bergmann
2011-10-03 18:18 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 24/30] ARM: omap2+: ensure that one of omap2/3/4 is selected Arnd Bergmann
2011-10-03 5:20 ` Santosh Shilimkar
2011-10-03 18:21 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 25/30] ARM: OMAP depends on MMU Arnd Bergmann
2011-10-03 5:21 ` Santosh Shilimkar
2011-10-03 18:22 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 26/30] ARM: omap: add board autoselection Arnd Bergmann
2011-10-03 5:28 ` Santosh Shilimkar
2011-10-03 9:11 ` Arnd Bergmann
2011-10-03 9:19 ` Santosh Shilimkar
2011-10-03 9:27 ` Cousson, Benoit
2011-10-03 9:54 ` Arnd Bergmann
2011-10-03 18:26 ` Tony Lindgren
2011-10-04 7:44 ` Arnd Bergmann
2011-10-04 15:57 ` Tony Lindgren
2011-10-04 19:29 ` Arnd Bergmann
2011-10-05 1:05 ` [GIT PULL] initial omap DT support for v3.2 merge window (Re: [PATCH 26/30] ARM: omap: add board autoselection) Tony Lindgren
2011-10-14 16:02 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 27/30] ARM: omap: select L2X0 cache on omap4 Arnd Bergmann
2011-10-03 5:29 ` Santosh Shilimkar
2011-10-03 18:27 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed Arnd Bergmann
2011-10-03 5:39 ` Santosh Shilimkar
2011-10-03 9:15 ` Arnd Bergmann
2011-10-03 9:33 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 29/30] ARM: omap: select USB_ARCH_HAS_EHCI only when USB is enabled Arnd Bergmann
2011-10-03 18:27 ` Tony Lindgren
2011-10-02 14:46 ` [PATCH 30/30] ARM: omap2: select ARM_AMBA for OMAP3_EMU Arnd Bergmann
2011-10-03 5:31 ` Santosh Shilimkar
2011-10-03 18:28 ` Tony Lindgren
2011-10-03 5:05 ` [PATCH 00/30] ARM/omap: omap specific randconfig fixes Santosh Shilimkar
2011-10-03 9:22 ` Arnd Bergmann
2011-10-03 9:42 ` Santosh Shilimkar
2011-10-03 18:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003174844.GQ6324@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox