Subject: [PATCH] regulator: max8649 Convert max8649 to user regmap api

From: [email-masked] (Mark Brown)
Date: Tue, 18 Oct 2011 13:30:22 +0100

On Tue, Oct 18, 2011 at 05:58:57PM +0800, Haojian Zhuang wrote:
> On Tue, Oct 18, 2011 at 3:23 PM,  <[email-masked]> wrote:
> > From: Jonghwan Choi <[email-masked]>

> Comments?

There's not really much more to say than the changelog TBH.

> > +static struct regmap_config max8649_regmap_config = {
> > + ? ? ? .reg_bits = 8,
> > + ? ? ? .val_bits = 8,
> > +};
> > +

> Register CHIP_ID1 & CHIP_ID2 are only readable. But it isn't mentioned
> in your code.

This is optional unless the device is using the cache code, especially
given that not even max_register has been provided.  For a conversion
like this providing access information is not needed.