From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/5] ARM: vexpress: Get rid of MMIO_P2V
Date: Tue, 29 Nov 2011 21:15:10 +0000 [thread overview]
Message-ID: <201111292115.10833.arnd@arndb.de> (raw)
In-Reply-To: <1322579473-8804-3-git-send-email-pawel.moll@arm.com>
On Tuesday 29 November 2011, Pawel Moll wrote:
> @@ -1,6 +1,3 @@
> -#define __MMIO_P2V(x) (((x) & 0xfffff) | (((x) & 0x0f000000) >> 4) | 0xf8000000)
> -#define MMIO_P2V(x) ((void __iomem *)__MMIO_P2V(x))
> -
...
> +
> +/* 2MB large area for motherboard's peripherals static mapping */
> +#define V2M_PERIPH 0xf8000000
> +#define V2M_PERIPH_P2V(offset) ((void __iomem *)(V2M_PERIPH | (offset)))
> +
> +/* Tile's peripherals static mappings should start here */
> +#define V2T_PERIPH 0xf8200000
> +#define V2T_PERIPH_P2V(offset) ((void __iomem *)(V2T_PERIPH | (offset)))
I think it would be even better if you could express the same with
pointer arithmetic instead of the macro, like:
#define V2M_PERIPH ((void __iomem *)0xf8000000)
#define V2T_PERIPH ((void __iomem *)0xf8200000)
and then instead of
+ gic_init(0, 29, V2T_PERIPH_P2V(A9_MPCORE_GIC_DIST),
+ V2T_PERIPH_P2V(A9_MPCORE_GIC_CPU));
do
+ gic_init(0, 29, V2T_PERIPH + A9_MPCORE_GIC_DIST,
+ V2T_PERIPH + A9_MPCORE_GIC_CPU);
and so on. This ends up being more readable IMHO because it
means you don't have to know what the macro does.
Arnd
next prev parent reply other threads:[~2011-11-29 21:15 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 15:11 [PATCH v3 0/5] Versatile Express DT support Pawel Moll
2011-11-29 15:11 ` [PATCH v3 1/5] ARM: versatile: Add missing ENDPROC to headsmp.S Pawel Moll
2011-11-29 15:11 ` [PATCH v3 2/5] ARM: vexpress: Get rid of MMIO_P2V Pawel Moll
2011-11-29 21:15 ` Arnd Bergmann [this message]
2011-11-30 11:34 ` Pawel Moll
2011-11-30 13:48 ` Arnd Bergmann
2011-11-30 13:52 ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 3/5] ARM: vexpress: Add DT support in v2m Pawel Moll
2011-11-29 21:19 ` Arnd Bergmann
2011-11-30 11:46 ` Pawel Moll
2011-11-30 13:34 ` Arnd Bergmann
2011-11-30 13:38 ` Pawel Moll
2011-11-30 15:10 ` Arnd Bergmann
2011-11-30 15:58 ` Dave Martin
2011-11-30 18:46 ` Pawel Moll
2011-12-01 10:57 ` Dave Martin
2011-12-05 16:25 ` Dave Martin
2011-12-05 16:30 ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 4/5] ARM: vexpress: Initial RS1 memory map support Pawel Moll
2011-11-30 15:37 ` Dave Martin
2011-11-30 17:15 ` Pawel Moll
2011-11-30 17:54 ` Dave Martin
2011-11-30 18:31 ` Pawel Moll
2011-11-30 20:43 ` Nicolas Pitre
2011-11-30 20:48 ` Mark Brown
2011-11-30 21:21 ` Stephen Warren
2011-11-30 21:38 ` Nicolas Pitre
2011-11-30 21:50 ` Russell King - ARM Linux
2011-12-01 3:36 ` Nicolas Pitre
2011-12-01 11:10 ` Mark Brown
2011-12-01 12:14 ` Dave Martin
2011-12-01 16:19 ` Stephen Warren
2011-12-02 17:41 ` Stephen Warren
2011-12-02 19:06 ` Marek Vasut
2011-12-02 19:28 ` Dave Martin
2011-12-02 22:52 ` Nicolas Pitre
2011-12-02 23:03 ` Marek Vasut
2011-12-01 18:37 ` Russell King - ARM Linux
2011-11-29 15:11 ` [PATCH v3 5/5] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4 Pawel Moll
2011-11-29 16:40 ` Dave Martin
2011-11-30 18:39 ` Pawel Moll
2011-12-01 12:21 ` Dave Martin
2011-12-05 17:24 ` Pawel Moll
2011-12-05 17:37 ` Dave Martin
2011-12-05 17:47 ` Pawel Moll
2011-12-05 18:06 ` Dave Martin
2011-11-29 17:00 ` [PATCH v3 0/5] Versatile Express DT support Dave Martin
2011-11-29 17:16 ` Pawel Moll
2011-11-30 10:48 ` Dave Martin
2011-11-30 11:14 ` Pawel Moll
2011-11-30 12:08 ` Dave Martin
2011-11-30 12:15 ` Pawel Moll
2011-11-29 21:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111292115.10833.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox