From: greg@kroah•com (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/7] tty: serial: support pinmux in pxa serial
Date: Wed, 30 Nov 2011 20:04:09 +0900 [thread overview]
Message-ID: <20111130110409.GA15460@kroah.com> (raw)
In-Reply-To: <CACRpkdbo7W9FATvygH234KRm68feRnNyCzDSTQZkt-oOzMPaZQ@mail.gmail.com>
On Mon, Nov 28, 2011 at 10:15:34AM +0100, Linus Walleij wrote:
> On Sat, Nov 26, 2011 at 12:09 AM, Haojian Zhuang
> <haojian.zhuang@marvell•com> wrote:
>
> > From: Haojian Zhuang <hzhuang1@hexinfolabs•org>
> >
> > PXA serial driver can configure pin directly.
> >
> > Signed-off-by: Haojian Zhuang <hzhuang1@hexinfolabs•org>
> (...)
> > + err_pmx:
> > + ? ? ? pinmux_disable(sport->pmx);
> > + ? ? ? pinmux_put(sport->pmx);
>
> There is this little discussion whether each individual driver should access
> it's pins or whether it should be done all centrally.
>
> After some thinking and resoning I actually think this may be best
> to have in each driver in most cases. The reason is that while it is
> possible to standardize for simple usecases (like this one, just activate
> it at probe() and deactivate it at remove()) it gets really complicated
> and hairy to have it in central places when we come to things like
> suspend()/resume(), idling and sometimes even
> runtime_[suspend|resume].
>
> So unless someone else disagrees or talks agains me, and
> provided this is how you want to do it for all PXA drivers:
> Acked-by: Linus Walleij <linus.walleij@linaro•org>
>
> I need Gregs ACK if you want it to go iin through the pinctrl
> tree.
Acked-by: Greg Kroah-Hartman <gregkh@suse•de>
next prev parent reply other threads:[~2011-11-30 11:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 23:08 [PATCH 0/7] pinctrl: enable pxa pinmux Haojian Zhuang
2011-11-25 23:08 ` [PATCH 1/7] pinctrl: enable pxa3xx pinmux Haojian Zhuang
2011-11-28 9:08 ` Linus Walleij
2011-11-28 9:50 ` Haojian Zhuang
2011-11-28 13:17 ` Linus Walleij
2011-11-28 13:23 ` Haojian Zhuang
2011-11-29 14:46 ` Arnd Bergmann
2011-11-29 15:36 ` Haojian Zhuang
2011-11-29 16:04 ` Arnd Bergmann
2011-11-28 20:21 ` Stephen Warren
2011-11-29 2:31 ` Eric Miao
2011-11-29 8:39 ` Linus Walleij
2011-11-29 8:56 ` Haojian Zhuang
2011-11-30 12:00 ` Linus Walleij
2011-11-25 23:08 ` [PATCH 2/7] gpio: make pxa gpio depend on pinmux Haojian Zhuang
2011-11-28 9:09 ` Linus Walleij
2011-11-25 23:09 ` [PATCH 3/7] ARM: pxa: enable pinmux in pxa pwm Haojian Zhuang
2011-11-28 9:18 ` Linus Walleij
2011-11-28 12:49 ` Russell King - ARM Linux
2011-11-25 23:09 ` [PATCH 4/7] tty: serial: support pinmux in pxa serial Haojian Zhuang
2011-11-28 9:15 ` Linus Walleij
2011-11-30 11:04 ` Greg KH [this message]
2011-11-25 23:09 ` [PATCH 5/7] fb: pxa: support pinmux operation Haojian Zhuang
2011-11-28 9:19 ` Linus Walleij
2011-12-02 21:53 ` Florian Tobias Schandinat
2011-12-05 13:07 ` Linus Walleij
2011-11-25 23:09 ` [PATCH 6/7] ARM: pxa: enable pinmux mapping in zylonite Haojian Zhuang
2011-11-26 3:53 ` Arnd Bergmann
2011-11-26 4:45 ` Haojian Zhuang
2011-11-28 9:32 ` Linus Walleij
2011-11-25 23:09 ` [PATCH 7/7] ARM: mmp: enable pinmux on ttc dkb Haojian Zhuang
2011-11-28 9:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130110409.GA15460@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox