From: rjw@sisk•pl (Rafael J. Wysocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] ARM: mach-shmobile: Use common always on power domain governor
Date: Thu, 1 Dec 2011 21:37:07 +0100 [thread overview]
Message-ID: <201112012137.08119.rjw@sisk.pl> (raw)
In-Reply-To: <1322765339-29879-2-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi,
On Thursday, December 01, 2011, Mark Brown wrote:
> Saves a tiny amount of code.
How so?
> Signed-off-by: Mark Brown <broonie@opensource•wolfsonmicro.com>
> ---
> arch/arm/mach-shmobile/pm-sh7372.c | 43 +----------------------------------
> 1 files changed, 2 insertions(+), 41 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/pm-sh7372.c b/arch/arm/mach-shmobile/pm-sh7372.c
> index adf1765..5f7d575 100644
> --- a/arch/arm/mach-shmobile/pm-sh7372.c
> +++ b/arch/arm/mach-shmobile/pm-sh7372.c
> @@ -162,45 +162,6 @@ static bool pd_active_wakeup(struct device *dev)
> return active_wakeup ? active_wakeup(dev) : true;
> }
>
> -static bool sh7372_power_down_forbidden(struct dev_pm_domain *domain)
> -{
> - return false;
> -}
> -
> -struct dev_power_governor sh7372_always_on_gov = {
> - .power_down_ok = sh7372_power_down_forbidden,
> - .stop_ok = default_stop_ok,
> -};
> -
> -static int sh7372_stop_dev(struct device *dev)
> -{
> - int (*stop)(struct device *dev);
> -
> - stop = dev_gpd_data(dev)->ops.stop;
> - if (stop) {
> - int ret = stop(dev);
> - if (ret)
> - return ret;
> - }
> - return pm_clk_suspend(dev);
> -}
> -
> -static int sh7372_start_dev(struct device *dev)
> -{
> - int (*start)(struct device *dev);
> - int ret;
> -
> - ret = pm_clk_resume(dev);
> - if (ret)
> - return ret;
> -
> - start = dev_gpd_data(dev)->ops.start;
> - if (start)
> - ret = start(dev);
> -
> - return ret;
> -}
> -
The above functions are actually necessary, please don't remove them
without introducing replacements.
> void sh7372_init_pm_domain(struct sh7372_pm_domain *sh7372_pd)
> {
> struct generic_pm_domain *genpd = &sh7372_pd->genpd;
> @@ -246,7 +207,7 @@ struct sh7372_pm_domain sh7372_d4 = {
>
> struct sh7372_pm_domain sh7372_a4r = {
> .bit_shift = 5,
> - .gov = &sh7372_always_on_gov,
> + .gov = &pm_domain_always_on_gov,
> .suspend = sh7372_a4r_suspend,
> .resume = sh7372_intcs_resume,
> .stay_on = true,
> @@ -262,7 +223,7 @@ struct sh7372_pm_domain sh7372_a3ri = {
>
> struct sh7372_pm_domain sh7372_a3sp = {
> .bit_shift = 11,
> - .gov = &sh7372_always_on_gov,
> + .gov = &pm_domain_always_on_gov,
> .no_debug = true,
> };
Thanks,
Rafael
next prev parent reply other threads:[~2011-12-01 20:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 18:48 [PATCH 1/3] PM: Provide an always on power domain governor Mark Brown
2011-12-01 18:48 ` [PATCH 2/3] ARM: mach-shmobile: Use common " Mark Brown
2011-12-01 20:37 ` Rafael J. Wysocki [this message]
2011-12-02 0:33 ` Mark Brown
2011-12-02 22:36 ` Rafael J. Wysocki
2011-12-03 11:03 ` Mark Brown
2011-12-03 22:31 ` Rafael J. Wysocki
2011-12-04 1:22 ` Mark Brown
2011-12-04 19:53 ` Rafael J. Wysocki
2011-12-04 1:24 ` [PATCH v2] " Mark Brown
2011-12-01 18:48 ` [PATCH 3/3] ARM: S3C64XX: Implement basic power domain support Mark Brown
2011-12-02 0:35 ` Kyungmin Park
2011-12-02 0:56 ` Mark Brown
2011-12-02 18:25 ` Tomasz Figa
2011-12-02 18:57 ` Mark Brown
2011-12-02 19:06 ` Tomasz Figa
2011-12-02 20:10 ` Sylwester Nawrocki
2011-12-02 21:07 ` Mark Brown
2011-12-07 21:44 ` Rafael J. Wysocki
2011-12-08 1:09 ` Mark Brown
2011-12-08 22:15 ` Rafael J. Wysocki
2011-12-08 22:22 ` Rafael J. Wysocki
2011-12-04 20:56 ` [PATCH 1/3] PM: Provide an always on power domain governor Rafael J. Wysocki
2011-12-04 23:10 ` Mark Brown
2011-12-05 0:15 ` Rafael J. Wysocki
2011-12-05 0:15 ` Mark Brown
2011-12-06 10:20 ` Kukjin Kim
2011-12-06 12:04 ` Marek Szyprowski
2011-12-06 14:33 ` Mark Brown
2011-12-06 21:39 ` Rafael J. Wysocki
2011-12-07 12:35 ` Mark Brown
2011-12-07 21:28 ` Rafael J. Wysocki
2011-12-08 0:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112012137.08119.rjw@sisk.pl \
--to=rjw@sisk$(echo .)pl \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox