From: plagnioj@jcrosoft•com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] at91 : move pm.h header to arch/arm/include/asm
Date: Mon, 9 Jan 2012 18:09:09 +0100 [thread overview]
Message-ID: <20120109170909.GL2854@game.jcrosoft.org> (raw)
In-Reply-To: <20120109164855.GK2854@game.jcrosoft.org>
On 17:48 Mon 09 Jan , Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:44 Mon 09 Jan , Russell King - ARM Linux wrote:
> > On Mon, Jan 09, 2012 at 02:54:32PM +0100, Daniel Lezcano wrote:
> > > On 01/09/2012 12:29 PM, Russell King - ARM Linux wrote:
> > > > On Mon, Jan 09, 2012 at 12:19:17PM +0100, Daniel Lezcano wrote:
> > > >> Actually, the header moves from :
> > > >>
> > > >> arch/arm/mach-at91/pm.h
> > > >> to:
> > > >> arch/arm/include/asm/at91_pm.h.
> > > >>
> > > >> This place and the renaming of the file complies with the comments of
> > > >> Russell,
> > > >
> > > > No it doesn't. There's absolutely no way in hell I want arch/arm/include/asm
> > > > to be littered with hundreds of crappy platform specific header files.
> > >
> > > Ok. Actually there are 9 pm.h files but I agree with a domino effect we
> > > can have more header files brought to this directory like "control.h",
> > > "powerdomain.h", etc ...
> > >
> > > Does it make sense to merge all the pm.h file in a single pm.h which
> > > will be located in arch/arm/include/asm ?
> >
> > No it doesn't. If moving something out of arch/arm means that we have to
> > buggerize the header files, then moving it out of arch/arm is the wrong
> > thing to do. What the need to bugger about with header files is telling
> > you is that the code you're moving (in its existing form) is intimitely
> > tied to the SoC.
> >
> > There's two solutions to that: either leave it where it is, or first
> > sort out why it's intimitely tied, and what can be done to remove its
> > dependence on the SoC.
> >
> > I've finally taken a deeper look at what's going on here...
> >
> > arch/arm/mach-at91/pm.h is full of crap:
> I work on it but work on other clean up first
this code need to be clean with the pm_slowclock.S too to support multiple soc
and we need to drop the at91_sys_read/write stuff too
I work on this right now
Best Regards,
J.
next prev parent reply other threads:[~2012-01-09 17:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 15:48 [PATCH 1/2] at91 : move pm.h header to arch/arm/include/asm Daniel Lezcano
2012-01-06 15:48 ` [PATCH 2/2] at91 : move cpuidle driver to drivers/cpuidle directory Daniel Lezcano
2012-01-06 17:30 ` [PATCH 1/2] at91 : move pm.h header to arch/arm/include/asm Arnd Bergmann
2012-01-06 23:19 ` Daniel Lezcano
2012-01-09 11:19 ` Daniel Lezcano
2012-01-09 11:29 ` Russell King - ARM Linux
2012-01-09 13:54 ` Daniel Lezcano
2012-01-09 14:44 ` Russell King - ARM Linux
2012-01-09 15:00 ` Daniel Lezcano
2012-01-09 16:48 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-09 17:09 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-01-09 17:41 ` Nicolas Ferre
2012-01-09 14:46 ` Rob Herring
2012-01-09 15:08 ` Daniel Lezcano
2012-01-07 10:45 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109170909.GL2854@game.jcrosoft.org \
--to=plagnioj@jcrosoft$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox