public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: dave.martin@linaro•org (Dave Martin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 3/7] ARM: ux500: add missing ENDPROC to headsmp.S
Date: Fri, 13 Jan 2012 14:24:15 +0000	[thread overview]
Message-ID: <20120113142415.GD2227@linaro.org> (raw)
In-Reply-To: <1326389476-11569-4-git-send-email-robherring2@gmail.com>

On Thu, Jan 12, 2012 at 11:31:12AM -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda•com>
> 
> Once the ENDPROC is in place, BSYM() in not longer necessary
> to get correct pointer to u8500_secondary_startup().
> 
> Signed-off-by: Rob Herring <rob.herring@calxeda•com>
> Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson•com>
> Cc: Linus Walleij <linus.walleij@stericsson•com>

The words at label 1 may be misaligned in a Thumb kernel, which is
undesirable.

It probably makes sense to add a .align 2 before that label
as part of this patch.

Cheers
---Dave

> ---
>  arch/arm/mach-ux500/headsmp.S |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-ux500/headsmp.S b/arch/arm/mach-ux500/headsmp.S
> index 64fa451..d03843d 100644
> --- a/arch/arm/mach-ux500/headsmp.S
> +++ b/arch/arm/mach-ux500/headsmp.S
> @@ -32,6 +32,7 @@ pen:	ldr	r7, [r6]
>  	 * should now contain the SVC stack for this core
>  	 */
>  	b	secondary_startup
> +ENDPROC(u8500_secondary_startup)
>  
>  1:	.long	.
>  	.long	pen_release
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2012-01-13 14:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-12 17:31 [PATCH v2 0/7] BSYM macro removal and secondary startup fixes Rob Herring
2012-01-12 17:31 ` [PATCH v2 1/7] ARM: versatile: Add missing ENDPROC to headsmp.S Rob Herring
2012-01-13 14:09   ` Dave Martin
2012-01-12 17:31 ` [PATCH v2 2/7] ARM: msm: " Rob Herring
2012-01-12 17:31 ` [PATCH v2 3/7] ARM: ux500: add " Rob Herring
2012-01-13 14:24   ` Dave Martin [this message]
2012-01-13 14:46     ` Rob Herring
2012-01-12 17:31 ` [PATCH v2 4/7] ARM: exynos: remove incorrect BSYM usage Rob Herring
2012-01-13 14:24   ` Dave Martin
2012-01-12 17:31 ` [PATCH v2 5/7] ARM: imx: " Rob Herring
2012-01-13 14:27   ` Dave Martin
2012-01-12 17:31 ` [PATCH v2 6/7] ARM: highbank: " Rob Herring
2012-01-13 14:29   ` Dave Martin
2012-01-12 17:31 ` [PATCH v2 7/7] ARM: make BSYM macro assembly only Rob Herring
2012-01-13 14:10   ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120113142415.GD2227@linaro.org \
    --to=dave.martin@linaro$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox