From: catalin.marinas@arm•com (Catalin Marinas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] Skip unnecessary pte makeup when clearing it.
Date: Wed, 18 Jan 2012 10:33:16 +0000 [thread overview]
Message-ID: <20120118103315.GB20028@arm.com> (raw)
In-Reply-To: <1326880345-17306-1-git-send-email-bill4carson@gmail.com>
On Wed, Jan 18, 2012 at 09:52:25AM +0000, bill4carson at gmail.com wrote:
> From: Bill Carson <bill4carson@gmail•com>
>
> If we are only about to clear a hardware pte entry, then pte makeup code is
> unnecessary for cpu_v7_set_pte_ext and armv6_set_pte_ext, so just skip it.
>
> Signed-off-by: Bill Carson <bill4carson@gmail•com>
> ---
> arch/arm/mm/proc-macros.S | 10 +++++-----
> arch/arm/mm/proc-v7-2level.S | 10 +++++-----
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/mm/proc-macros.S b/arch/arm/mm/proc-macros.S
> index 2d8ff3a..11288b3 100644
> --- a/arch/arm/mm/proc-macros.S
> +++ b/arch/arm/mm/proc-macros.S
> @@ -138,6 +138,10 @@
> .macro armv6_set_pte_ext pfx
> str r1, [r0], #2048 @ linux version
>
> + tst r1, #L_PTE_YOUNG
> + tstne r1, #L_PTE_PRESENT
> + moveq r3, #0
> + moveq set_pte
As Uwe said, "beq" here and you could use numerical labels like "1f".
--
Catalin
next prev parent reply other threads:[~2012-01-18 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 9:52 [PATCH] Skip unnecessary pte makeup when clearing it bill4carson at gmail.com
2012-01-18 10:20 ` Uwe Kleine-König
2012-01-19 1:52 ` bill4carson
2012-01-18 10:33 ` Catalin Marinas [this message]
2012-01-19 1:57 ` bill4carson
-- strict thread matches above, loose matches on Subject: below --
2012-01-30 1:47 [PATCH V2] " bill4carson at gmail.com
2012-01-30 1:47 ` [PATCH] " bill4carson at gmail.com
2012-01-30 7:58 ` Uwe Kleine-König
2012-01-30 8:29 ` bill4carson
2012-01-30 8:36 [PATCH V3] " bill4carson at gmail.com
2012-01-30 8:36 ` [PATCH] " bill4carson at gmail.com
2012-02-03 6:54 ` Uwe Kleine-König
2012-02-03 7:43 ` bill4carson
2012-02-03 7:48 ` bill4carson
2012-02-03 9:35 ` Uwe Kleine-König
2012-02-03 10:09 ` bill4carson
2012-02-03 11:27 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118103315.GB20028@arm.com \
--to=catalin.marinas@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox