Subject: [PATCH 15/15] arch/arm/mach-omap2/smartreflex.c: add missing iounmap

From: [email-masked] (Tony Lindgren)
Date: Thu, 26 Jan 2012 16:37:05 -0800

* Julia Lawall <[email-masked]> [120112 01:23]:
> From: Julia Lawall <[email-masked]>
> 
> Add missing iounmap in error handling code, in a case where the function
> already preforms iounmap on some other execution path.

Thanks I'll apply this into omap fixes branch.

Regards,

Tony
 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression e;
> statement S,S1;
> int ret;
> @@
> e = \(ioremap\|ioremap_nocache\)(...)
> ... when != iounmap(e)
> if (<+...e...+>) S
> ... when any
>     when != iounmap(e)
> *if (...)
>    { ... when != iounmap(e)
>      return ...; }
> ... when any
> iounmap(e);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <[email-masked]>
> 
> ---
>  arch/arm/mach-omap2/smartreflex.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index 9dd9345..7e755bb 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -897,7 +897,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  		ret = sr_late_init(sr_info);
>  		if (ret) {
>  			pr_warning("%s: Error in SR late init\n", __func__);
> -			return ret;
> +			goto err_iounmap;
>  		}
>  	}
>  
>