Subject: [PATCH v6 07/15] ARM: SoC: convert MSM SMP to SoC descriptor

From: [email-masked] (David Brown)
Date: Wed, 8 Feb 2012 15:39:07 -0800

On Wed, Feb 08, 2012 at 12:30:51AM +0000, Marc Zyngier wrote:

> @@ -146,6 +152,9 @@ MACHINE_END
>  #ifdef CONFIG_OF
>  /* TODO: General device tree support for all MSM. */
>  DT_MACHINE_START(MSM_DT, "Qualcomm MSM (Flattened Device Tree)")
> +	.soc = &msm_soc_desc,
> +	.fixup = msm8x60_fixup,
> +	.reserve = msm8x60_reserve,
>  	.map_io = msm8x60_map_io,
>  	.init_irq = msm8x60_init_irq,
>  	.init_machine = msm8x60_dt_init,

The fixup and reserve aren't really needed (and probably not wanted)
for the DT board.  The fixup doesn't actually work, since it modifies
the tags, which don't exist.  The reservation should be passed in the
DT itself, since that has a mechanism for it.

Otherwise, the MSM part looks ok.

Acked-By: David Brown <[email-masked]>

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.