From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 02/10] pwm: Allow chips to support multiple PWMs.
Date: Thu, 23 Feb 2012 14:07:12 +0000 [thread overview]
Message-ID: <201202231407.12981.arnd@arndb.de> (raw)
In-Reply-To: <20120223081235.GC8621@avionic-0098.mockup.avionic-design.de>
On Thursday 23 February 2012, Thierry Reding wrote:
> > Is this only used for the device tree functions? If so, I would recommend
> > making it less generic and always search for a device node.
>
> It is currently only used to look up a struct pwm_chip for a given struct
> device_node, yes. But I can see other uses for this. For instance this could
> be useful if we ever want to provide an alternative way of requesting a PWM
> on a per-chip basis.
Nah, just keep it simple for now. If we need it later, we can still
add something like this back, but for now it's just a source of
confusion and possible bugs.
> I was again basically looking at gpiolib for inspiration (maybe I should stop
> doing that :-). Maybe gpiolib should be reworked to use seq_file's iterator
> interface as well? Just in case anybody else turns to gpiolib for
> inspiration.
Good idea. Would you be able to send a patch for that, too? I would guess
converting both at the same time would be easier for you than splitting
the work between two people.
ARnd
next prev parent reply other threads:[~2012-02-23 14:07 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 15:17 [PATCH v3 00/10] Add PWM framework and device tree support Thierry Reding
2012-02-22 15:17 ` [PATCH v3 01/10] PWM: add pwm framework support Thierry Reding
2012-02-22 15:17 ` [PATCH v3 02/10] pwm: Allow chips to support multiple PWMs Thierry Reding
2012-02-22 16:34 ` Arnd Bergmann
2012-02-23 8:12 ` Thierry Reding
2012-02-23 14:07 ` Arnd Bergmann [this message]
2012-02-23 16:04 ` Thierry Reding
2012-03-03 19:32 ` Thierry Reding
2012-03-06 15:38 ` Arnd Bergmann
2012-03-06 19:17 ` Thierry Reding
2012-02-22 15:17 ` [PATCH v3 03/10] of: Add PWM support Thierry Reding
2012-02-22 16:15 ` Arnd Bergmann
2012-02-23 7:55 ` Thierry Reding
2012-02-23 14:03 ` Arnd Bergmann
2012-02-24 6:47 ` Thierry Reding
2012-02-24 16:58 ` Arnd Bergmann
2012-02-25 12:33 ` Sascha Hauer
2012-02-25 23:08 ` Ryan Mallon
2012-02-22 15:17 ` [PATCH v3 04/10] arm/tegra: Fix PWM clock programming Thierry Reding
2012-02-28 21:01 ` Stephen Warren
2012-03-03 22:47 ` Thierry Reding
2012-03-05 17:33 ` Stephen Warren
2012-02-22 15:17 ` [PATCH v3 05/10] arm/tegra: Provide clock for only one PWM controller Thierry Reding
2012-02-22 15:17 ` [PATCH v3 06/10] pwm: Add NVIDIA Tegra SoC support Thierry Reding
2012-02-23 1:47 ` Ryan Mallon
2012-02-23 8:14 ` Thierry Reding
2012-02-23 9:25 ` Ryan Mallon
2012-02-24 6:48 ` Thierry Reding
2012-02-28 21:14 ` Stephen Warren
2012-03-03 22:42 ` Thierry Reding
2012-03-05 3:39 ` Olof Johansson
2012-03-05 7:00 ` Thierry Reding
2012-02-22 15:17 ` [PATCH v3 07/10] arm/tegra: Add PWFM controller device tree probing Thierry Reding
2012-02-28 21:20 ` Stephen Warren
2012-03-03 22:54 ` Thierry Reding
2012-03-04 20:39 ` Arnd Bergmann
2012-03-05 17:51 ` Stephen Warren
2012-03-05 18:15 ` Thierry Reding
2012-03-05 18:39 ` Stephen Warren
2012-02-22 15:17 ` [PATCH v3 08/10] pwm: Add Blackfin support Thierry Reding
2012-02-22 15:17 ` [PATCH v3 09/10] pwm: Add PXA support Thierry Reding
2012-02-22 15:40 ` Arnd Bergmann
2012-02-23 6:10 ` Thierry Reding
2012-02-22 15:17 ` [PATCH v3 10/10] pwm-backlight: Add rudimentary device tree support Thierry Reding
2012-02-22 16:02 ` [PATCH v3 00/10] Add PWM framework and " Arnd Bergmann
2012-02-23 7:29 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202231407.12981.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox