From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 6/6] ARM: at91: add Shutdown Controller (SHDWC) DT support
Date: Wed, 7 Mar 2012 18:49:36 +0000 [thread overview]
Message-ID: <201203071849.36867.arnd@arndb.de> (raw)
In-Reply-To: <20120307173828.GD17087@game.jcrosoft.org>
On Wednesday 07 March 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:24 Fri 02 Mar , Arnd Bergmann wrote:
> > On Friday 02 March 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > + }
> > > +
> > > + if (of_device_is_compatible(np, "atmel,at91sam9x5-shdwc")) {
> > > + have_rtt = false;
> > > + have_rtc = true;
> > > + } else if (of_device_is_compatible(np, "atmel,at91sam9rl-shdwc")) {
> > > + have_rtt = true;
> > > + have_rtc = true;
> > > + } else {
> > > + have_rtt = true;
> > > + have_rtc = false;
> > > + }
> > > +
> > > + if (have_rtc && of_property_read_bool(np, "atmel,wakeup-rtc-timer"))
> > > + mode |= AT91_SHDW_RTCWKEN;
> > > +
> > > + if (have_rtt && of_property_read_bool(np, "atmel,wakeup-rtt-timer"))
> > > + mode |= AT91_SHDW_RTTWKEN;
> > > +
> > > + at91_shdwc_write(AT91_SHDW_MR, wakeup_mode | mode);
> > > +
> >
> > Hi Jean-Christophe,
> >
> > I don't understand why you check the specific part here. Isn't it enough to
> > check the property when you already mandate that they can only be present
> > on devices that support the specific wakeup?
> >
> > If there is a good explanation for that, maybe add a code comment why it's
> > required.
> some wake update source exist on few soc and we are not supposed to set the
> bit otherwise
>
I still don't understand: Doesn't the property already give the information?
In general, you should try to encode these things in specific properties instead of
checking the compatible property.
Arnd
next prev parent reply other threads:[~2012-03-07 18:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 19:28 [PATCH 0/6] AT91 more DT bindings Jean-Christophe PLAGNIOL-VILLARD
2012-03-02 19:54 ` [PATCH 1/6] ARM: at91/dt: add specific DT soc init Jean-Christophe PLAGNIOL-VILLARD
2012-03-02 19:54 ` [PATCH 2/6] ARM: at91: add pmc DT support Jean-Christophe PLAGNIOL-VILLARD
2012-03-02 19:54 ` [PATCH 3/6] ARM: at91: always enable sam9 restart Jean-Christophe PLAGNIOL-VILLARD
2012-03-02 19:54 ` [PATCH 4/6] ARM: at91: add RSTC (Reset Controller) dt support Jean-Christophe PLAGNIOL-VILLARD
2012-03-02 19:54 ` [PATCH 5/6] ARM: at91: add ram controller DT support Jean-Christophe PLAGNIOL-VILLARD
2012-03-07 19:58 ` Rob Herring
2012-03-08 6:13 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 14:12 ` Rob Herring
2012-03-08 14:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 15:24 ` Rob Herring
2012-03-08 16:51 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 17:13 ` Rob Herring
2012-03-02 19:54 ` [PATCH 6/6] ARM: at91: add Shutdown Controller (SHDWC) " Jean-Christophe PLAGNIOL-VILLARD
2012-03-02 20:24 ` Arnd Bergmann
2012-03-07 17:38 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-07 18:49 ` Arnd Bergmann [this message]
2012-03-07 18:59 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-07 19:54 ` Rob Herring
2012-03-07 21:16 ` Arnd Bergmann
2012-03-07 17:39 ` [PATCH 0/6] AT91 more DT bindings Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203071849.36867.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox