From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 09/12] ARM: EXYNOS: add support get_core_count() for EXYNOS5250
Date: Tue, 13 Mar 2012 16:15:49 +0000 [thread overview]
Message-ID: <201203131615.49846.arnd@arndb.de> (raw)
In-Reply-To: <1331652643-12626-10-git-send-email-kgene.kim@samsung.com>
On Tuesday 13 March 2012, Kukjin Kim wrote:
> The EXYNOS5250 has two Cortex-A15 cores and there's no
> need to call scu_enable() in platform_smp_prepare_cpus().
>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung•com>
Can you explain this patch more? It only seems to make the
code less generic, but there is no indication if calling
the scu_get_core_count() function is actually wrong on
exynos5.
Arnd
> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
> index 0f2035a..36c3984 100644
> --- a/arch/arm/mach-exynos/platsmp.c
> +++ b/arch/arm/mach-exynos/platsmp.c
> @@ -166,7 +166,10 @@ void __init smp_init_cpus(void)
> void __iomem *scu_base = scu_base_addr();
> unsigned int i, ncores;
>
> - ncores = scu_base ? scu_get_core_count(scu_base) : 1;
> + if (soc_is_exynos5250())
> + ncores = 2;
> + else
> + ncores = scu_base ? scu_get_core_count(scu_base) : 1;
>
> /* sanity check */
> if (ncores > nr_cpu_ids) {
> @@ -183,8 +186,8 @@ void __init smp_init_cpus(void)
>
> void __init platform_smp_prepare_cpus(unsigned int max_cpus)
> {
> -
> - scu_enable(scu_base_addr());
> + if (!soc_is_exynos5250())
> + scu_enable(scu_base_addr());
>
> /*
> * Write the address of secondary startup into the
next prev parent reply other threads:[~2012-03-13 16:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 15:30 [PATCH v3 00/12] ARM: EXYNOS: add support new EXYNOS5250 Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 01/12] ARM: EXYNOS: to declare static for mach-exynos/common.c Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 02/12] ARM: EXYNOS: use exynos_init_uarts() instead of exynos4_init_uarts() Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 03/12] ARM: EXYNOS: add clock part for EXYNOS5250 SoC Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 04/12] ARM: EXYNOS: add initial setup-i2c0 for EXYNOS5 Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 05/12] ARM: EXYNOS: add support uart for EXYNOS4 and EXYNOS5 Kukjin Kim
2012-03-13 16:13 ` Arnd Bergmann
2012-03-14 7:06 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 06/12] ARM: EXYNOS: add support for EXYNOS5250 SoC Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 07/12] ARM: EXYNOS: add interrupt definitions for EXYNOS5250 Kukjin Kim
2012-03-14 3:42 ` Olof Johansson
2012-03-14 6:30 ` Kukjin Kim
2012-03-14 5:27 ` Thomas Abraham
2012-03-14 6:32 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 08/12] ARM: EXYNOS: support EINT for EXYNOS4 and EXYNOS5 Kukjin Kim
2012-03-14 3:52 ` Olof Johansson
2012-03-14 6:33 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 09/12] ARM: EXYNOS: add support get_core_count() for EXYNOS5250 Kukjin Kim
2012-03-13 16:15 ` Arnd Bergmann [this message]
2012-03-14 6:49 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 10/12] ARM: EXYNOS: add support ARCH_EXYNOS5 for EXYNOS5 SoCs Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 11/12] ARM: EXYNOS: add support device tree enabled board file for EXYNOS5 Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 12/12] ARM: dts: add initial dts file for EXYNOS5250, SMDK5250 Kukjin Kim
2012-03-14 3:56 ` Olof Johansson
2012-03-14 6:43 ` Kukjin Kim
2012-03-13 16:22 ` [PATCH v3 00/12] ARM: EXYNOS: add support new EXYNOS5250 Arnd Bergmann
2012-03-14 3:57 ` Olof Johansson
2012-03-14 7:08 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203131615.49846.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox