public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 05/10] ARM: ux500: db8500: list most devices in the snowball device tree
Date: Wed, 14 Mar 2012 13:59:45 +0000	[thread overview]
Message-ID: <201203141359.46109.arnd@arndb.de> (raw)
In-Reply-To: <1331730306-11461-6-git-send-email-lee.jones@linaro.org>

On Wednesday 14 March 2012, Lee Jones wrote:
> +               pmu {
> +                       compatible = "arm,cortex-a9-pmu";
> +                       interrupts = <7>;
> +               };
> +
> +               rtc at 80154000 {
> +                       compatible = "stericsson,db8500-rtc";
> +                       reg = <0x80154000 0x1000>;
> +                       interrupts = <18>;
> +               };
> +
> +               gpio0: gpio at 8012e000 {
> +                       compatible = "stericsson,db8500-gpio",
> +                               "stmicroelectronics,nomadik-gpio";
> +                       reg =  <0x8012e000 0x80>;
> +                       interrupts = <119>;
> +                       supports-sleepmode;
> +                       gpio-controller;
> +               };

Reading through it one more time, I realized that all the interrupt
numbers are incorrect here and you fix them up one by one in the
later patches. I think it would be more logical if you could just
fix correct them here and then later just add the additional properties
and enable the device.

	Arnd

  reply	other threads:[~2012-03-14 13:59 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 13:04 [PATCH 0/10] ARM: ux500: Enable Snowball for Device Tree Lee Jones
2012-03-14 13:04 ` [PATCH 01/10] ARM: ux500: CONFIG: Enable Device Tree support for future endeavours Lee Jones
2012-03-15 14:38   ` Linus Walleij
2012-03-14 13:04 ` [PATCH 02/10] ARM: ux500: Initial Device Tree support for Snowball Lee Jones
2012-03-14 13:58   ` Arnd Bergmann
2012-03-14 14:37     ` Lee Jones
2012-03-14 14:56       ` Arnd Bergmann
2012-03-15 14:39         ` Linus Walleij
2012-03-14 13:04 ` [PATCH 03/10] ARM: ux500: combine the board init functions for DT boot Lee Jones
2012-03-15 14:39   ` Linus Walleij
2012-03-14 13:05 ` [PATCH 04/10] ARM: ux500: split dts file for snowball into generic part Lee Jones
2012-03-15 15:56   ` Linus Walleij
2012-03-14 13:05 ` [PATCH 05/10] ARM: ux500: db8500: list most devices in the snowball device tree Lee Jones
2012-03-14 13:59   ` Arnd Bergmann [this message]
2012-03-15 16:05     ` Linus Walleij
2012-03-14 13:05 ` [PATCH 06/10] ARM: ux500: Enable Cortex-A9 GIC (Generic Interrupt Controller) in Device Tree Lee Jones
2012-03-14 14:00   ` Arnd Bergmann
2012-03-15 16:06   ` Linus Walleij
2012-03-14 13:05 ` [PATCH 07/10] ARM: ux500: Provide local timer support for " Lee Jones
2012-03-14 14:00   ` Arnd Bergmann
2012-03-14 15:02   ` Rob Herring
2012-03-14 15:16     ` Marc Zyngier
2012-03-15 17:47   ` Linus Walleij
2012-03-14 13:05 ` [PATCH 08/10] ARM: ux500: Enable PL011 AMBA UART Controller " Lee Jones
2012-03-14 14:01   ` Arnd Bergmann
2012-03-14 15:00   ` Rob Herring
2012-03-14 15:36     ` Lee Jones
2012-03-15 16:08   ` Linus Walleij
2012-03-14 13:05 ` [PATCH 09/10] ARM: ux500: Enable PL310 Level 2 Cache Controller in " Lee Jones
2012-03-14 14:01   ` Arnd Bergmann
2012-03-15 16:09   ` Linus Walleij
2012-03-14 13:05 ` [PATCH 10/10] ARM: ux500: Enable PL022 SSP " Lee Jones
2012-03-14 14:05   ` Arnd Bergmann
2012-03-15 16:13     ` Linus Walleij
2012-03-15 16:11   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203141359.46109.arnd@arndb.de \
    --to=arnd@arndb$(echo .)de \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox