From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards
Date: Tue, 27 Mar 2012 13:59:16 +0000 [thread overview]
Message-ID: <201203271359.16553.arnd@arndb.de> (raw)
In-Reply-To: <CAOh2x==7gNt2Jb3-EHz9-R1pTy6zL93FmUmTBMdpYUnW3F=9Uw@mail.gmail.com>
On Tuesday 27 March 2012, viresh kumar wrote:
> On Mar 27, 2012 7:07 PM, "Arnd Bergmann" <arnd@arndb•de> wrote:
> >
> > On Tuesday 27 March 2012, Viresh Kumar wrote:
> > > On 3/27/2012 4:45 PM, Arnd Bergmann wrote:
> > > > On Tuesday 27 March 2012, Viresh Kumar wrote:
> > > > The normal way is to turn around the logic so you don't have to include this test
> > > > at all. Just have one soc-specific init_machine and map_io function, that calls
> > > > both soc-specific and shared soc functions, e.g.
> > >
> > > But with that, i need multiple DT_MACHINE_START(). Isn't it?
> > > Is this advisable?
> >
> > Having one DT_MACHINE_START per soc is ok if it helps you. Of course if you
> > have multiple ones that are basically identical, it's simpler to just
> > combine them.
>
> That's what i have done in V1. And then only i came to
> The first problem i mentioned.
Right. I mean you can feel free to do whichever works best for you. If it's easy
to combine the DT_MACHINE_START sections, then do, otherwise don't.
> > Obviously that only works when you initialize the clocks from init_early()
> > instead of from map_io(), but I think that would be the cleanest choice
> > if you want to have single function with run-time dependencies.
>
> But then why not use machine_init() for doing this too.
That would be even better. I think we should generally try do initialization
as late as possible, ideally from initcalls. The init_early() function should
only be used for code that absolutely has to be run from setup_arch() and
no later, while the map_io() function should ideally only be used to set up
the static mappings and nothing else.
Arnd
next prev parent reply other threads:[~2012-03-27 13:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 14:47 [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards Stefan Roese
2012-03-13 16:44 ` Arnd Bergmann
2012-03-14 7:08 ` Viresh Kumar
2012-03-14 9:58 ` Arnd Bergmann
2012-03-14 10:02 ` Viresh Kumar
2012-03-14 7:40 ` Stefan Roese
2012-03-14 9:48 ` Arnd Bergmann
2012-03-14 10:36 ` Stefan Roese
2012-03-14 13:27 ` Arnd Bergmann
2012-03-14 13:43 ` Stefan Roese
2012-03-14 14:09 ` Arnd Bergmann
2012-03-14 13:44 ` Rob Herring
2012-03-14 7:05 ` Viresh Kumar
2012-03-14 7:20 ` Stefan Roese
2012-03-15 8:48 ` Stefan Roese
2012-03-15 9:00 ` Viresh Kumar
2012-03-15 10:38 ` Stefan Roese
2012-03-15 10:40 ` Viresh Kumar
2012-03-15 13:39 ` Arnd Bergmann
2012-03-21 11:32 ` Viresh Kumar
2012-03-21 12:36 ` Arnd Bergmann
2012-03-21 13:28 ` viresh kumar
2012-03-21 14:04 ` Arnd Bergmann
2012-03-21 14:18 ` viresh kumar
2012-03-21 14:42 ` Arnd Bergmann
2012-03-21 18:26 ` Arnd Bergmann
2012-03-22 0:45 ` viresh kumar
2012-03-22 8:10 ` Arnd Bergmann
[not found] ` <CAOh2x=k6ZfamB8DnPgVPjxZ7E1gTuHOQYg6s1Nd1ybA+TSquWA@mail.gmail.com>
2012-03-22 14:20 ` Arnd Bergmann
2012-03-27 10:27 ` Viresh Kumar
2012-03-27 11:15 ` Arnd Bergmann
2012-03-27 11:27 ` Viresh Kumar
2012-03-27 11:45 ` Viresh Kumar
2012-03-27 11:59 ` Arnd Bergmann
[not found] ` <CAOh2x==7gNt2Jb3-EHz9-R1pTy6zL93FmUmTBMdpYUnW3F=9Uw@mail.gmail.com>
2012-03-27 13:59 ` Arnd Bergmann [this message]
2012-03-28 5:03 ` Viresh Kumar
2012-03-28 8:13 ` Arnd Bergmann
2012-03-14 8:48 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203271359.16553.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox