From: akpm@linux-foundation•org (Andrew Morton)
To: linux-arm-kernel@lists•infradead.org
Subject: [V2 2/4] rtc: fix 88pm860x rtc irq enable callback
Date: Tue, 27 Mar 2012 16:47:59 -0700 [thread overview]
Message-ID: <20120327164759.ec04c62e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1331259874-26503-1-git-send-email-jtzhou@marvell.com>
On Fri, 9 Mar 2012 10:24:34 +0800
"Jett.Zhou" <jtzhou@marvell•com> wrote:
> According to 88pm860x spec, rtc alarm irq enable control is bit3 for
> RTC_ALARM_EN, so fix it.
>
> Signed-off-by: Jett.Zhou <jtzhou@marvell•com>
> ---
> drivers/rtc/rtc-88pm860x.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-88pm860x.c b/drivers/rtc/rtc-88pm860x.c
> index f04761e..8b72b4c 100644
> --- a/drivers/rtc/rtc-88pm860x.c
> +++ b/drivers/rtc/rtc-88pm860x.c
> @@ -72,9 +72,9 @@ static int pm860x_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
> struct pm860x_rtc_info *info = dev_get_drvdata(dev);
>
> if (enabled)
> - pm860x_set_bits(info->i2c, PM8607_RTC1, ALARM, ALARM);
> + pm860x_set_bits(info->i2c, PM8607_RTC1, ALARM_EN, ALARM_EN);
> else
> - pm860x_set_bits(info->i2c, PM8607_RTC1, ALARM, 0);
> + pm860x_set_bits(info->i2c, PM8607_RTC1, ALARM_EN, 0);
> return 0;
> }
It's surprising that the driver has been in-tree for a year and nobody
has noticed this bug. This makes me wonder if the fix is wrong.
Has the patch been runtime tested?
next prev parent reply other threads:[~2012-03-27 23:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 11:47 [V1 1/4] regulator: fix the ldo configure according to 88pm860x spec Jett.Zhou
[not found] ` <1329997662-2931-3-git-send-email-jtzhou@marvell.com>
2012-02-24 8:41 ` [V1 3/4] mfd: Add ability to wake the system for 88pm860x Dmitry Torokhov
[not found] ` <1330073981-25793-1-git-send-email-jtzhou@marvell.com>
2012-02-27 14:45 ` [V2 " Samuel Ortiz
[not found] ` <1331259874-26503-1-git-send-email-jtzhou@marvell.com>
2012-03-27 23:47 ` Andrew Morton [this message]
2012-03-28 10:06 ` [V2 2/4] rtc: fix 88pm860x rtc irq enable callback Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327164759.ec04c62e.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox