From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] PATA host controller driver for ep93xx
Date: Tue, 3 Apr 2012 07:41:15 +0000 [thread overview]
Message-ID: <201204030741.16596.arnd@arndb.de> (raw)
In-Reply-To: <4F7A5781.3000507@gmail.com>
On Tuesday 03 April 2012, Ryan Mallon wrote:
> On 02/04/12 17:52, Rafal Prylowski wrote:
>
> > Yes, I already prepared a version of the driver in which IDE register
> > addresses are coded as enums instead of using ata_port->ioaddr structure.
> > I will post updated version, when I get feedback from Ryan if enums
> > or defines are preferred.
>
> I would prefer defines, simply because it looks odd having an enum which
> has multiple names defined to the same value, and most drivers tend to
> use defines rather than enums for registers. It's not a big deal though,
> and certainly not a show stopper.
I tend to prefer enums, but I agree that it's a minor issue and I generally
don't even mention it in reviews.
Arnd
next prev parent reply other threads:[~2012-04-03 7:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 8:10 [PATCH 0/3] Add PATA host controller support for Cirrus Logic EP93xx CPU Rafal Prylowski
2012-03-29 8:17 ` [PATCH 1/3] PATA host controller driver for ep93xx Rafal Prylowski
2012-03-29 17:25 ` H Hartley Sweeten
2012-03-30 8:13 ` Rafal Prylowski
2012-03-29 22:21 ` Ryan Mallon
2012-03-30 10:13 ` Rafal Prylowski
2012-03-29 22:24 ` Ryan Mallon
2012-03-30 8:19 ` Rafal Prylowski
2012-03-30 20:18 ` Arnd Bergmann
2012-04-02 7:52 ` Rafal Prylowski
2012-04-02 8:08 ` Arnd Bergmann
2012-04-02 9:28 ` Rafal Prylowski
2012-04-02 10:24 ` Arnd Bergmann
2012-04-03 1:50 ` Ryan Mallon
2012-04-03 7:41 ` Arnd Bergmann [this message]
2012-03-29 8:19 ` [PATCH 2/3] ep93xx: IDE driver platform support code Rafal Prylowski
2012-03-29 16:26 ` H Hartley Sweeten
2012-03-30 8:29 ` Rafal Prylowski
2012-03-29 8:20 ` [PATCH 3/3] ep93xx: Add IDE support to edb93xx boards Rafal Prylowski
2012-03-29 16:32 ` H Hartley Sweeten
2012-03-30 8:32 ` Rafal Prylowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204030741.16596.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox