From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/9] Add support for SPEAr13xx SoCs
Date: Sat, 21 Apr 2012 12:24:47 +0000 [thread overview]
Message-ID: <201204211224.47826.arnd@arndb.de> (raw)
In-Reply-To: <CAOh2x=kX93nDDTfVq-ERBF=UDRZAUSwnwCuO35R+E-SZjcFUag@mail.gmail.com>
On Saturday 21 April 2012, viresh kumar wrote:
> On 4/20/12, Arnd Bergmann <arnd@arndb•de> wrote:
> > I've looked at all the platform specific bits and they look pretty good,
> > great work! I have ignored the pinctrl and clock drivers and hope that the
> > respective maintainers will be able to judge them well.
> >
> > There are a few places where you still hardcode stuff that could be turned
> > into device tree properties, but those are corner cases and you have an
> > existing platform here that you've done a great amount of excellent cleanups
> > to in the last weeks, so my feeling is that all the platform code can go in
> > when you take care of the stuff that I've commented on, most of those things
> > should be simple.
>
> Have fixed most of stuff you pointed to. Check V2.
>
Wow, that was fast ;-)
Can you comment on the ones you did not address? In particular,
I'd like to understand why you put the SPEAR1310_RAS_CTRL*
register definitions into a globally visible header file.
Arnd
next prev parent reply other threads:[~2012-04-21 12:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 17:22 [PATCH 0/9] Add support for SPEAr13xx SoCs Viresh Kumar
2012-04-20 17:22 ` [PATCH 1/9] SPEAr13xx: Add header files Viresh Kumar
2012-04-20 17:52 ` Arnd Bergmann
2012-04-21 12:27 ` viresh kumar
2012-04-21 18:37 ` Arnd Bergmann
2012-04-23 11:47 ` viresh kumar
2012-04-23 12:25 ` viresh kumar
2012-04-20 17:22 ` [PATCH 2/9] SPEAr13xx: Add source files Viresh Kumar
2012-04-20 18:15 ` Arnd Bergmann
2012-04-21 12:23 ` viresh kumar
2012-04-21 18:31 ` Arnd Bergmann
2012-04-20 17:22 ` [PATCH 3/9] SPEAr13xx: Add common clock framework support Viresh Kumar
2012-04-23 21:43 ` Turquette, Mike
2012-04-24 3:57 ` Viresh Kumar
2012-04-20 17:22 ` [PATCH 4/9] pinctrl: SPEAr: Create macro for declaring GPIO PINS Viresh Kumar
2012-04-20 17:22 ` [PATCH 6/9] SPEAr13xx: Add dts and dtsi files Viresh Kumar
2012-04-20 17:22 ` [PATCH 7/9] SPEAr13xx: Add compilation support Viresh Kumar
2012-04-20 17:22 ` [PATCH 8/9] SPEAr13xx: Add defconfig Viresh Kumar
2012-04-20 17:22 ` [PATCH 9/9] SPEAr: Update MAINTAINERS and Documentation Viresh Kumar
2012-04-20 18:21 ` [PATCH 0/9] Add support for SPEAr13xx SoCs Arnd Bergmann
2012-04-21 12:17 ` viresh kumar
2012-04-21 12:24 ` Arnd Bergmann [this message]
2012-04-21 12:29 ` viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204211224.47826.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox