From: aisheng.dong@freescale•com (Dong Aisheng)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/4] pinctrl: pinctrl-imx: add imx pinctrl core driver
Date: Fri, 27 Apr 2012 19:24:57 +0800 [thread overview]
Message-ID: <20120427112457.GG826@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120427085402.GV2234@S2101-09.ap.freescale.net>
On Fri, Apr 27, 2012 at 04:54:05PM +0800, Shawn Guo wrote:
> On Thu, Apr 26, 2012 at 10:40:25PM +0800, Dong Aisheng wrote:
> > +/**
> > + * struct imx_pin_reg - describe a pin reg map
> > + * The last 3 members are used for select input setting
> > + * @pid: pin id
> > + * @mux_reg: mux register offset
> > + * @conf_reg: config register offset
> > + * @mux_mode: mux mode
> > + * @input_reg: select input register offset for this mux if any
> > + * 0 if no select input setting needed.
> > + * @input_val: the value set to select input register
> > + */
> > +struct imx_pin_reg {
> > + unsigned int pid;
> > + unsigned int mux_reg;
> > + unsigned int conf_reg;
> > + unsigned int mux_mode;
> > + unsigned int input_reg;
> > + unsigned int input_val;
> > +};
>
> Since the array of this struct is big, I would suggest define the type
> of the members as size-efficient as possible, for example, u16 is enough
> for pid, and reg offset, while u8 is enough for mux_mode?
>
Yes, reasonable.
Will change to that in v4.
Regards
Dong Aisheng
next prev parent reply other threads:[~2012-04-27 11:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 14:40 [PATCH v4 1/4] dt: add of_get_child_count helper function Dong Aisheng
2012-04-26 14:40 ` [PATCH v3 2/4] pinctrl: pinctrl-imx: add imx pinctrl core driver Dong Aisheng
2012-04-26 14:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-26 15:15 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-27 5:48 ` Shawn Guo
2012-04-27 6:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-27 7:25 ` Shawn Guo
2012-04-27 7:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-27 8:11 ` Shawn Guo
2012-04-27 9:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-27 3:48 ` Dong Aisheng
2012-04-27 6:31 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-27 7:30 ` Sascha Hauer
2012-04-26 14:44 ` Dong Aisheng
2012-04-27 5:30 ` Shawn Guo
2012-04-27 8:54 ` Shawn Guo
2012-04-27 11:24 ` Dong Aisheng [this message]
2012-04-26 14:40 ` [PATCH v3 4/4] mmc: sdhci-imx-esdhc: convert to use pinctrl subsystem Dong Aisheng
2012-04-26 16:32 ` Stephen Warren
2012-04-27 7:35 ` Sascha Hauer
2012-04-27 8:29 ` Dong Aisheng
2012-04-27 8:26 ` Shawn Guo
2012-04-27 8:31 ` Sascha Hauer
2012-04-27 8:54 ` Dong Aisheng
2012-04-27 8:47 ` Sascha Hauer
2012-04-27 9:13 ` Dong Aisheng
2012-04-26 16:24 ` [PATCH v4 1/4] dt: add of_get_child_count helper function Stephen Warren
2012-04-27 3:28 ` Dong Aisheng
2012-04-27 3:36 ` [PATCH v5 1/1] " Dong Aisheng
2012-04-27 15:25 ` Stephen Warren
2012-05-01 23:05 ` Linus Walleij
[not found] ` <1335451227-27709-3-git-send-email-b29396@freescale.com>
2012-04-27 5:35 ` [PATCH v3 3/4] pinctrl: pinctrl-imx: add imx6q pinctrl driver Shawn Guo
2012-04-27 6:45 ` Sascha Hauer
2012-04-27 7:16 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427112457.GG826@shlinux2.ap.freescale.net \
--to=aisheng.dong@freescale$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox