Subject: [PATCH 2/7] ARM: OMAP2+: Clean up wrapping multiple objects in Makefile

From: [email-masked] (Tony Lindgren)
Date: Wed, 2 May 2012 08:49:49 -0700

* Shilimkar, Santosh <[email-masked]> [120502 03:18]:
> On Wed, May 2, 2012 at 3:26 PM, Russell King - ARM Linux
> <[email-masked]> wrote:
> > On Wed, May 02, 2012 at 03:18:08PM +0530, Santosh Shilimkar wrote:
> >> Signed-off-by: Santosh Shilimkar <[email-masked]>
> >> ---
> >> ?arch/arm/mach-omap2/Makefile | ?160 ++++++++++++++++++++---------------------
> >> ?1 files changed, 78 insertions(+), 82 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> >> index 56ed62e..669e2b1 100644
> >> --- a/arch/arm/mach-omap2/Makefile
> >> +++ b/arch/arm/mach-omap2/Makefile
> >> @@ -24,10 +24,11 @@ endif
> >> ?obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
> >>
> >> ?# SMP support ONLY available for OMAP4
> >> +
> >> ?obj-$(CONFIG_SMP) ? ? ? ? ? ? ? ? ? ?+= omap-smp.o omap-headsmp.o
> >> ?obj-$(CONFIG_HOTPLUG_CPU) ? ? ? ? ? ?+= omap-hotplug.o
> >> -obj-$(CONFIG_ARCH_OMAP4) ? ? ? ? ? ? += omap4-common.o omap-wakeupgen.o \
> >> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?sleep44xx.o
> >> +obj-$(CONFIG_ARCH_OMAP4) ? ? ? ? ? ? += omap4-common.o omap-wakeupgen.o
> >> +obj-$(CONFIG_ARCH_OMAP4) ? ? ? ? ? ? += sleep44xx.o
> >
> > Using \ in makefiles really isn't a problem. ?I don't think this is something
> > which we need to do, and it just creates additional changes where none is
> > required.
> 
> Tony might give better reasoning for this change since he suggested it.

Mostly for making it cleaner to build shared objects between omap4 and omap5
without adding things like:

+obj-$(CONFIG_ARCH_OMAP5)                += omap4-common.o omap-wakeupgen.o \
+                                          sleep44xx.o

But of course more localized changes will do there too to prepare adding
omap5.

Regards,

Tony