From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup
Date: Thu, 10 May 2012 12:11:52 -0700 [thread overview]
Message-ID: <20120510191152.GN21851@atomide.com> (raw)
In-Reply-To: <1336655139-8908-1-git-send-email-govindraj.raja@ti.com>
* Govindraj.R <govindraj.raja@ti•com> [120510 06:09]:
> From: "Govindraj.R" <govindraj.raja@ti•com>
>
> The commit (bce492c0 ARM: OMAP2+: UART: Fix incorrect population of
> default uart pads) removed default uart pads that where getting populated
> and which was making rx pin wakeup capable. If uart pads was used in
Nitpick.. this should say "were used" here ^^^
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -295,8 +353,7 @@ void __init omap_serial_board_init(struct omap_uart_port_info *info)
> bdata.pads = NULL;
> bdata.pads_cnt = 0;
>
> - if (cpu_is_omap44xx() || cpu_is_omap34xx())
> - omap_serial_fill_default_pads(&bdata);
> + omap_serial_check_wakeup(&bdata, uart);
Should this section become:
if (!info) {
omap_serial_check_wakeup(&bdata, uart);
omap_serial_init_port(&bdata, NULL);
} else {
omap_serial_init_port(&bdata, &info[uart->num]);
}
As if you have bdata, then there should not be anything to mux,
right?
Regards,
Tony
next prev parent reply other threads:[~2012-05-10 19:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 13:05 [PATCH v2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup Govindraj.R
2012-05-10 19:11 ` Tony Lindgren [this message]
2012-05-11 9:13 ` Raja, Govindraj
2012-05-11 8:34 ` Russ Dill
2012-05-11 9:15 ` Raja, Govindraj
2012-05-11 9:40 ` [PATCH v3] " Govindraj.R
2012-05-23 23:11 ` Kevin Hilman
2012-06-05 11:08 ` Tony Lindgren
2012-06-05 11:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510191152.GN21851@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox