From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] ARM: clps711x: Used own subarch directory for store header file
Date: Mon, 14 May 2012 18:46:12 +0000 [thread overview]
Message-ID: <201205141846.12491.arnd@arndb.de> (raw)
In-Reply-To: <1337017571-16208-1-git-send-email-shc_work@mail.ru>
On Monday 14 May 2012, Alexander Shiyan wrote:
>
> Patch created for arm-soc clps711x/cleanup branch.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail•ru>
Hi Alexander,
I've applied these patches to the clps711x/cleanup branch, but I'm
not too happy with the submission form.
Most patches were missing a useful description, which I've had to add
from looking at the contents. In the future I'd expect you to add such
a description yourself, ideally one that explains why you need such a
change, which is something that is not always obvious from the patch
itself.
A comment like "Patch created for arm-soc clps711x/cleanup branch."
is completely meaningless for the changeset description. It should
either go into the [PATCH 0/4] cover letter that git-format-patch
can create for you, or if you send only a single patch, you can put
it between the '---' line and the diffstat, so it appears in the
email but not in the changelog.
Finally, don't send patches just one at a time when you know that
you have more of them. It's annoying for me that I have to go back
to the same branch and merge it repeatedly when you do this. Better
send the entire series at once, or for longer ones, send a git
pull request.
I have not pulled the branches into the main next/cleanup branch,
so they are not yet scheduled for the next merge window (the earlier
two ones are). Let me know whether you have more patches for this series,
I'll put it in once you are done.
Arnd
next prev parent reply other threads:[~2012-05-14 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 17:46 [PATCH 1/4] ARM: clps711x: Used own subarch directory for store header file Alexander Shiyan
2012-05-14 17:46 ` [PATCH 2/4] ARM: clps711x: Added missing register definitions Alexander Shiyan
2012-05-14 17:46 ` [PATCH 3/4] ARM: clps711x: Added note about support EP731x CPU to Kconfig Alexander Shiyan
2012-05-14 17:46 ` [PATCH 4/4] ARM clps711x: Removed unused header mach/time.h Alexander Shiyan
2012-05-14 18:46 ` Arnd Bergmann [this message]
[not found] ` <E1SU1SU-0003hN-FS.shc_work-mail-ru@f197.mail.ru>
2012-05-14 20:13 ` [PATCH 1/4] ARM: clps711x: Used own subarch directory for store header file Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205141846.12491.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox