Subject: [PATCH 5/8] MXS: Add USB PHY driver

From: [email-masked] (Marek Vasut)
Date: Wed, 16 May 2012 15:37:21 +0200

Dear Peter Chen,

> On Tue, May 15, 2012 at 10:23:36AM +0200, Marek Vasut wrote:
> > Add driver that controls the built-in USB PHY in the i.MX233/i.MX28. This
> > enables the PHY upon powerup and shuts it down on shutdown.
> 
> Please add i.mx6q .
> 
> > +config USB_MXS_PHY
> > +	tristate "Freescale i.MX28 USB PHY support"
> > +	select USB_OTG_UTILS
> > +	select USB_IMX_COMPOSITE
> 
> Seems you will not use imx_otg.c with chipidea framework.

Good catch :)

> 
> > + *
> > + * Freescale i.MX28 USB PHY driver.
> 
> use mxs

Now ... I think we have two waring opinions in here :)

> > + *
> > +
> > +	/* Enable FS/LS compatibility and wakeup IRQs. */
> > +	val = BM_USBPHY_CTRL_ENUTMILEVEL2 | BM_USBPHY_CTRL_ENUTMILEVEL3 |
> > +		BM_USBPHY_CTRL_ENIRQWAKEUP;
> > +
> > +	/* Enable IRQ sources. */
> > +	val |= BM_USBPHY_CTRL_ENIDCHG_WKUP | BM_USBPHY_CTRL_ENDPDMCHG_WKUP |
> > +		BM_USBPHY_CTRL_ENVBUSCHG_WKUP;
> 
> Please forget wakeup function currently, as it will make things more
> complicated.
> 
> > +
> > +	writel(val, x->io_priv + HW_USBPHY_CTRL_SET);
> > +
> > +	return 0;
> > +}
> > +
> > +	/* Disable FS/LS compatibility and wakeup IRQs. */
> > +	val = BM_USBPHY_CTRL_ENUTMILEVEL2 | BM_USBPHY_CTRL_ENUTMILEVEL3 |
> > +		BM_USBPHY_CTRL_ENIRQWAKEUP;
> > +
> > +	/* Disable IRQ sources. */
> > +	val |= BM_USBPHY_CTRL_ENIDCHG_WKUP | BM_USBPHY_CTRL_ENDPDMCHG_WKUP |
> > +		BM_USBPHY_CTRL_ENVBUSCHG_WKUP;
> > +
> 
> The same with above
> 
> > +
> > +MODULE_ALIAS("platform:mxs-usb-phy");
> > +MODULE_AUTHOR("Marek Vasut <[email-masked]>");
> > +MODULE_DESCRIPTION("Freescale i.MX28 USB PHY driver");
> 
> mxs
> 
> > +MODULE_LICENSE("GPL");

Best regards,
Marek Vasut