Subject: [PATCH v2 6/6] spi: s3c64xx: add device tree support

From: [email-masked] (Grant Likely)
Date: Sat, 19 May 2012 23:10:26 -0600

On Fri, 18 May 2012 15:03:33 +0530, Thomas Abraham <[email-masked]> wrote:
> Add support for device based discovery.
> 
> Signed-off-by: Thomas Abraham <[email-masked]>
> Acked-by: Jaswinder Singh <[email-masked]>

Acked-by: Grant Likely <[email-masked]>

... but one nitpick below...

> +#ifdef CONFIG_OF
> +static const struct of_device_id s3c64xx_spi_dt_match[] = {
> +	{ .compatible = "samsung,exynos4210-spi",
> +			.data = (void *)EXYNOS4_SPI_PORT_CONFIG,

This looks completely backwards.  EXYNOS4_SPI_PORT_CONFIG casts a
pointer to a kernel_ulong_t, and this casts it right back to a
pointer.  The cast should be removed entirely from the macro, and the
platform_device_id table should have the cast from pointer to ulong.

g.