From: gregkh@linuxfoundation•org (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 01/12] usb: otg: add notify_connect_change callback
Date: Mon, 21 May 2012 06:03:10 -0700 [thread overview]
Message-ID: <20120521130310.GA18926@kroah.com> (raw)
In-Reply-To: <20120521093840.GM8633@arwen.pp.htv.fi>
On Mon, May 21, 2012 at 12:38:41PM +0300, Felipe Balbi wrote:
> On Mon, May 21, 2012 at 05:36:16PM +0800, Richard Zhao wrote:
> > On Mon, May 21, 2012 at 12:26:36PM +0300, Felipe Balbi wrote:
> > > On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote:
> > > > This let usb phy driver has a chance to change hw settings when connect
> > > > status change.
> > > >
> > > > Signed-off-by: Richard Zhao <richard.zhao@freescale•com>
> > > > ---
> > > > include/linux/usb/otg.h | 13 +++++++++++++
> > > > 1 files changed, 13 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h
> > > > index 38ab3f4..385641d 100644
> > > > --- a/include/linux/usb/otg.h
> > > > +++ b/include/linux/usb/otg.h
> > > > @@ -117,6 +117,10 @@ struct usb_phy {
> > > > int (*set_suspend)(struct usb_phy *x,
> > > > int suspend);
> > > >
> > > > + /* notify phy connect status change */
> > > > + int (*notify_connect_change)(struct usb_phy *x,
> > > > + int port,
> > > > + int connected);
> > > > };
> > > >
> > > >
> > > > @@ -252,6 +256,15 @@ usb_phy_set_suspend(struct usb_phy *x, int suspend)
> > > > }
> > > >
> > > > static inline int
> > > > +usb_phy_notify_connect_change(struct usb_phy *x, int port, int connected)
> > > > +{
> > > > + if (x->notify_connect_change != NULL)
> > >
> > > you don't need this != NULL. See that no other wrapper has it. Keep
> > > consistency.
> > notify_connect_change callback is not a must. I just let the phy driver
> > have a chance to do whatever it needs to do.
>
> what I meant was:
>
> - if (x->notify_connect_change != NULL)
> + if (x->notify_connect_change)
>
> > > Also, this is the kind of stuff that I have been queueing for Greg so I
> > > should be in Cc.
> > Ah, I'm really sorry. I just find out I used the result of get_maintainer
> > for v1 patchset.
>
> hmm... ok, looks like I should patch MAINTAINERS file for that :-p
>
> Greg, is it ok ?
Yes, please send me a patch for MAINTAINERS for this.
greg k-h
next prev parent reply other threads:[~2012-05-21 13:03 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 9:23 [PATCH v2 00/12] add imx usb driver for mx28/6x Richard Zhao
2012-05-21 9:23 ` [PATCH v2 01/12] usb: otg: add notify_connect_change callback Richard Zhao
2012-05-21 9:26 ` Felipe Balbi
2012-05-21 9:36 ` Richard Zhao
2012-05-21 9:38 ` Felipe Balbi
2012-05-21 10:19 ` Richard Zhao
2012-05-21 13:03 ` Greg KH [this message]
2012-05-21 13:05 ` Greg KH
2012-05-21 17:36 ` Marek Vasut
2012-05-21 17:47 ` Greg KH
2012-05-21 18:32 ` Marek Vasut
2012-05-21 18:40 ` Greg KH
2012-05-21 19:27 ` Marek Vasut
2012-05-22 0:27 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 02/12] usb: chipidea: permit driver bindings pass phy pointer Richard Zhao
2012-05-22 4:22 ` Marek Vasut
2012-05-22 9:59 ` Alexander Shishkin
2012-05-22 14:07 ` Marek Vasut
2012-05-22 15:14 ` Richard Zhao
2012-05-23 1:35 ` Chen Peter-B29397
2012-05-23 8:08 ` Alexander Shishkin
2012-05-21 9:23 ` [PATCH v2 03/12] usb: ehci-hcd: notify phy when connect change Richard Zhao
2012-05-22 4:23 ` Marek Vasut
2012-05-22 4:36 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 04/12] usb: otg: add basic mxs phy driver support Richard Zhao
2012-05-21 9:23 ` [PATCH v2 05/12] usb: chipidea: add imx driver binding Richard Zhao
2012-05-22 4:30 ` Marek Vasut
2012-05-22 4:51 ` Richard Zhao
2012-05-22 9:56 ` Alexander Shishkin
2012-05-22 10:06 ` Felipe Balbi
2012-05-22 10:31 ` Richard Zhao
2012-05-22 10:35 ` Felipe Balbi
2012-05-22 10:41 ` Alexander Shishkin
2012-05-22 15:06 ` Richard Zhao
2012-05-23 13:02 ` Alexander Shishkin
2012-05-23 13:09 ` Felipe Balbi
2012-05-23 13:13 ` Alexander Shishkin
2012-05-22 13:52 ` Shawn Guo
2012-05-22 13:55 ` Felipe Balbi
2012-05-22 10:21 ` Alexander Shishkin
2012-05-22 10:24 ` Alexander Shishkin
2012-05-22 15:30 ` Richard Zhao
2012-05-22 15:28 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 06/12] ARM: imx6q: correct device name of usbphy and usb controller clock export Richard Zhao
2012-05-22 4:31 ` Marek Vasut
2012-05-22 4:56 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 07/12] ARM: imx6q: add config-on-boot gpios Richard Zhao
2012-05-22 3:17 ` Shawn Guo
2012-05-22 3:25 ` Marek Vasut
2012-05-22 3:32 ` Shawn Guo
2012-05-22 4:20 ` Marek Vasut
2012-05-22 4:42 ` Shawn Guo
2012-05-22 5:22 ` Marek Vasut
2012-05-22 5:25 ` Shawn Guo
2012-05-22 5:27 ` Marek Vasut
2012-05-22 6:07 ` Richard Zhao
2012-05-22 3:38 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 08/12] ARM: imx6q: add usbphy clocks Richard Zhao
2012-05-22 4:32 ` Marek Vasut
2012-05-22 4:45 ` Shawn Guo
2012-05-22 5:22 ` Marek Vasut
2012-05-22 4:59 ` Richard Zhao
2012-05-22 5:37 ` Shawn Guo
2012-05-22 6:08 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 09/12] ARM: imx6q: disable usb charger detector Richard Zhao
2012-05-22 3:48 ` Shawn Guo
2012-05-22 4:32 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 10/12] ARM: dts: imx6q-sabrelite: add usb devices Richard Zhao
2012-05-22 5:10 ` Shawn Guo
2012-05-22 5:59 ` Richard Zhao
2012-05-22 6:08 ` Shawn Guo
2012-05-22 6:19 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 11/12] ARM: mxs: clk_register_clkdev mx28 usb clocks Richard Zhao
2012-05-22 4:48 ` Shawn Guo
2012-05-22 5:01 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 12/12] ARM: dts: imx28-evk: add usb devices Richard Zhao
2012-05-22 4:52 ` Shawn Guo
2012-05-22 5:03 ` Richard Zhao
2012-05-22 5:24 ` Marek Vasut
2012-05-21 19:34 ` [PATCH v2 00/12] add imx usb driver for mx28/6x Fabio Estevam
2012-05-21 19:41 ` Marek Vasut
2012-05-21 19:47 ` Subodh Nijsure
2012-05-21 20:07 ` Marek Vasut
2012-05-22 1:38 ` Chen Peter-B29397
2012-05-22 1:41 ` Richard Zhao
2012-05-22 1:44 ` Chen Peter-B29397
2012-05-22 1:51 ` Richard Zhao
2012-05-22 2:00 ` Shawn Guo
2012-05-22 5:08 ` Richard Zhao
2012-05-22 13:13 ` Dirk Behme
2012-05-24 3:38 ` Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521130310.GA18926@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox