From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RFC] serial/8250: Adjusting FIFO parameters for LPC32xx
Date: Sun, 27 May 2012 10:23:16 +0000 [thread overview]
Message-ID: <201205271023.16742.arnd@arndb.de> (raw)
In-Reply-To: <4FC1EEA7.2060109@antcom.de>
On Sunday 27 May 2012, Roland Stigge wrote:
> I did it via the following modification in of_serial.c:
>
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -179,6 +179,7 @@ static struct of_device_id __devinitdata of_platform_serial_table[] = {
> { .compatible = "ns16450", .data = (void *)PORT_16450, },
> { .compatible = "ns16550a", .data = (void *)PORT_16550A, },
> { .compatible = "ns16550", .data = (void *)PORT_16550, },
> + { .compatible = "ns16654", .data = (void *)PORT_16654, },
> { .compatible = "ns16750", .data = (void *)PORT_16750, },
> { .compatible = "ns16850", .data = (void *)PORT_16850, },
> { .compatible = "nvidia,tegra20-uart", .data = (void *)PORT_TEGRA, },
>
> Works for now, will need to test more thoroughly with LPC32xx (note that
> the manual explicitly mentions "downwards compatible with the INS16Cx50"
> and "Register locations conform to ?550 industry standard" but nothing
> about an EFR register which 16654 is configured for in 8250.c).
>
> The patch should be useful in of_serial anyway (even without the LPC32xx
> case).
>
> Wondering if it should rather be .compatible = "st16654"?
> Will prepare a patch with adjustment of Documentation/.../of-serial.txt when
> we agree on sth.
I think st16654 would be better than ns16654 here, yes.
Actually some of the other entries are wrong, too. The ns8250 entry should
be i8250, and I guess the 16750 and 16850 were also not made by national.
Arnd
next prev parent reply other threads:[~2012-05-27 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 16:11 [PATCH RFC] serial/8250: Adjusting FIFO parameters for LPC32xx Roland Stigge
2012-05-27 2:32 ` Arnd Bergmann
2012-05-27 9:06 ` Roland Stigge
2012-05-27 10:23 ` Arnd Bergmann [this message]
2012-05-27 11:37 ` Roland Stigge
2012-05-27 12:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205271023.16742.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox