Subject: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

From: [email-masked] (Mark Brown)
Date: Thu, 31 May 2012 12:36:59 +0100

On Thu, May 31, 2012 at 10:05:42AM +0800, Thomas Abraham wrote:
> On 30 May 2012 18:13, Mark Brown <[email-masked]> wrote:

> > No there isn't. ?You've got things like s3c64xx_device_spi0 in
> > arch/arm/plat-samsung/devs.c (which you'd expect since the resources
> > that are passed in for memory mapping, DMA and interrupt vary with the
> > SoC). ?The bit of code I was querying just changes "s3c64xx-spi" to
> > "s3c6410-spi" at runtime in that structure which seems like a waste of
> > time.

> So is the concern only with the change of device name from
> "s3c64xx-spi" to "s3c6410-spi"? Is there any concern with changing the
> name of the static spi platform device (s3c64xx_device_spi0/1/2) at
> runtime which then is used to select a driver data?

No, you're not getting it at all.  The changing at runtime is the
problem, it's achieving nothing except making the code more fragile and
obscure.  Those devices will always come out with exactly the same name
so we should just assign that name statically.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120531/a83da38e/attachment.sig>