From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11
Date: Tue, 3 Jul 2012 13:19:40 +0000 [thread overview]
Message-ID: <201207031319.40884.arnd@arndb.de> (raw)
In-Reply-To: <20120703130042.GA10007@mail.gnudd.com>
On Tuesday 03 July 2012, Alessandro Rubini wrote:
> Peter Anvin:
> > There is no problem with adding ARM or !X86 dependencies to drivers
> > now and fixing them later or as required.
>
> Ok. This is my summary of the compilation errors I have when
> enabling ARM_AMBA undex x86 and enabling everything that appears
> in "make oldconfig":
>
>
> This is a sum up of the errors in all driver that are
> enabled by telling "CONFIG_ARM_AMBA=y" in the x86 config.
>
> drivers/dma/pl330.c: register names conflict with arch symbols
> proposed fix: use proper prefix names
>
> drivers/dma/amba-pl08x.c: needs <asm/hardware/pl080.h>
> proposed fix: move pl080.h to include/linux
Note that there is already an include/linux/amba/pl08x.h.
I would just move the few parts of pl080.h that are actually
needed with global visibility there, and move the rest
to drivers/dma/.
> drivers/gpio/gpio-pl061.c: uses chained_irq_enter/exit
> proposed fix: depend on CONFIG_ARM (the function only exists in arm)
>
> drivers/mmc/host/mmci.c: uses <asm/sizes.h>
> drivers/mmc/host/mmci.c: uses readsl/writesl
> proposed fix: use linux/sizes.h and provide readsl/writesl like others do
Ack on the linux/sizes.h, that definitely makes sense.
I'm not sure I want to spread readsl/writesl beyond the architectures
that already have it. Maybe instead change the driver to use ioread32_rep,
which is already available on all architectures and is defined the
same way as readsl on ARM.
> drivers/watchdog/sp805_wdt.c: uses writel_relaxed
> proposed fix: depend on CONFIG_ARM (this is a spear-only cell by now)
This one on the other hand makes sense to be defined on all architectures
IMHO. I don't mind restricting the driver to ARM for now, but having
a generic writel_relaxed would be nice.
Arnd
next prev parent reply other threads:[~2012-07-03 13:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1338222460.git.rubini@gnudd.com>
2012-05-28 16:37 ` [PATCH V2 1/6] sizes.h: move from asm-generic to <linux/sizes.h> Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 2/6] amba: use the new linux/sizes.h Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 3/6] ARM: " Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 4/6] serial: " Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11 Alessandro Rubini
2012-06-28 20:06 ` H. Peter Anvin
2012-07-01 10:44 ` Alessandro Rubini
2012-07-01 10:59 ` Russell King - ARM Linux
2012-07-01 11:04 ` Alessandro Rubini
2012-07-01 11:11 ` Russell King - ARM Linux
2012-07-01 11:58 ` Jassi Brar
2012-07-01 12:10 ` Russell King - ARM Linux
2012-07-01 13:11 ` Jassi Brar
2012-07-01 14:13 ` H. Peter Anvin
2012-07-02 16:58 ` Arnd Bergmann
2012-07-02 18:05 ` Mark Brown
2012-07-02 18:07 ` H. Peter Anvin
2012-07-02 18:33 ` Mark Brown
2012-07-02 19:41 ` H. Peter Anvin
2012-07-03 11:05 ` Mark Brown
2012-07-03 13:00 ` Alessandro Rubini
2012-07-03 13:19 ` Arnd Bergmann [this message]
2012-07-03 13:26 ` Alessandro Rubini
2012-07-03 19:46 ` Russell King - ARM Linux
2012-07-03 19:34 ` Russell King - ARM Linux
2012-08-05 20:28 ` Linus Walleij
2012-08-07 10:06 ` Kukjin Kim
2012-05-28 16:38 ` [PATCH V2 6/6] drivers/amba: add support for a PCI bridge Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207031319.40884.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox