From: aisheng.dong@freescale•com (Dong Aisheng)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] regulator: core: remove sysfs entry properly in regulator_put
Date: Thu, 5 Jul 2012 16:28:46 +0800 [thread overview]
Message-ID: <20120705082845.GF14589@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <1341469182-5079-1-git-send-email-shawn.guo@linaro.org>
On Thu, Jul 05, 2012 at 02:19:42PM +0800, Shawn Guo wrote:
> With changes introduced by commit 222cc7b (regulator: core: Allow
> multiple requests of a single supply mapping) on create_regulator,
> regulator_put needs a corresponding update on sysfs entry removing.
>
> Also regulator->dev still needs to get assigned in create_regulator,
> otherwise, sysfs_remove_link call in regulator_put will get bypassed.
>
> Reported-by: Fabio Estevam <festevam@gmail•com>
> Signed-off-by: Shawn Guo <shawn.guo@linaro•org>
> ---
> drivers/regulator/core.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
Good catch.
Tested-by: Dong Aisheng <dong.aisheng@linaro•org>
Acked-by: Dong Aisheng <dong.aisheng@linaro•org>
Regards
Dong Aisheng
next prev parent reply other threads:[~2012-07-05 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 3:53 mx28evk: kernel dump on sgtl5000 probe Fabio Estevam
2012-07-04 4:36 ` Marek Vasut
2012-07-05 6:19 ` [PATCH] regulator: core: remove sysfs entry properly in regulator_put Shawn Guo
2012-07-05 8:28 ` Dong Aisheng [this message]
2012-07-05 12:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705082845.GF14589@shlinux2.ap.freescale.net \
--to=aisheng.dong@freescale$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox