From: gregkh@linuxfoundation•org (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change
Date: Mon, 9 Jul 2012 09:57:57 -0700 [thread overview]
Message-ID: <20120709165757.GA6024@kroah.com> (raw)
In-Reply-To: <1341673008-29808-7-git-send-email-richard.zhao@freescale.com>
On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote:
> Phy may need to change settings when port connect change.
>
> Signed-off-by: Richard Zhao <richard.zhao@freescale•com>
> Tested-by: Subodh Nijsure <snijsure@grid-net•com>
> ---
> drivers/usb/core/hub.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 4cc8dc9..2ba9d84 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -20,6 +20,7 @@
> #include <linux/usb.h>
> #include <linux/usbdevice_fs.h>
> #include <linux/usb/hcd.h>
> +#include <linux/usb/otg.h>
> #include <linux/usb/quirks.h>
> #include <linux/kthread.h>
> #include <linux/mutex.h>
> @@ -4037,6 +4038,13 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1,
> }
> }
>
> + if (unlikely(hcd->phy && !hdev->parent)) {
Why is this "unlikely"? And why mark it as such, is this a "fast path"
that needs the compiler to know this hint to optimize things here?
Please don't use likely() or unlikely() except in places it really is
needed, _and_ you have measured the difference. Have you done so in
this place?
thanks,
greg k-h
next prev parent reply other threads:[~2012-07-09 16:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-07 14:56 [PATCH v9 REBASE 0/9] add imx usb driver based on Greg next tree Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 1/9] USB: Chipidea: rename struct ci13xxx variables from udc to ci Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 2/9] USB: Chipidea: add unified ci13xxx_{add, remove}_device for platform drivers Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 3/9] USB: Chipidea: add ci13xxx device id management Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 4/9] usb: chipidea: select USB_EHCI_ROOT_HUB_TT in USB_CHIPIDEA_HOST of Kconfig Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 5/9] usb: otg: add notify_connect/notify_disconnect callback Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change Richard Zhao
2012-07-09 16:57 ` Greg KH [this message]
2012-07-10 1:44 ` Richard Zhao
2012-07-10 14:24 ` Alan Stern
2012-07-10 14:53 ` Richard Zhao
2012-07-10 3:14 ` Richard Zhao
2012-07-10 3:22 ` Marek Vasut
2012-07-10 11:20 ` Richard Zhao
2012-07-10 11:38 ` Marek Vasut
2012-07-10 15:07 ` Alan Stern
2012-07-11 2:53 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 7/9] usb: chipidea: permit driver bindings pass phy pointer Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 8/9] usb: otg: add basic mxs phy driver support Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 9/9] usb: chipidea: add imx platform driver Richard Zhao
2012-07-09 17:02 ` [PATCH v9 REBASE 0/9] add imx usb driver based on Greg next tree Greg KH
2012-07-10 1:52 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709165757.GA6024@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox