From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: OMAP2+: cpu: Make cpu_class_is_omap2 true for all non-omap1 platforms
Date: Tue, 10 Jul 2012 02:18:21 -0700 [thread overview]
Message-ID: <20120710091820.GR1122@atomide.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A83EA69AA3@DBDE01.ent.ti.com>
* Hiremath, Vaibhav <hvaibhav@ti•com> [120710 02:15]:
> On Tue, Jul 10, 2012 at 14:11:08, Tony Lindgren wrote:
> > * Hiremath, Vaibhav <hvaibhav@ti•com> [120627 13:37]:
> > > --- a/arch/arm/plat-omap/include/plat/cpu.h
> > > +++ b/arch/arm/plat-omap/include/plat/cpu.h
> > > @@ -42,7 +42,14 @@
> > > #define OMAP2_DEVICE_TYPE_GP 3
> > > #define OMAP2_DEVICE_TYPE_BAD 4
> > >
> > > +#ifdef CONFIG_ARCH_OMAP2PLUS
> > > int omap_type(void);
> > > +#else
> > > +inline static int omap_type(void)
> > > +{
> > > + /* Always return GP, since it is not being used anyway for omap1 */
> > > + return OMAP2_DEVICE_TYPE_GP;
> > > +}
> > > +#endif
> > >
> > > /*
> > > * omap_rev bits:
> >
> > Just to follow-up on this, looks like we need to postpone this
> > for v3.7. While at it, we need to make sure all soc_is_omapxxxx()
> > are false by default.
> >
>
> Just FYI, I had submitted V2 of this patch.
>
> > What you're suggesting above would also depend on some MULTI_ARCH
> > option set if multiple ARM architectures are selected. Above patch
> > would only optimize things when ARCH_OMAP2PLUS alone is selected.
> >
>
> Isn't this only applicable for ARCH_OMAP2PLUS and OMAP1?? And above patch
> take cares of both, as OMAP1 and 2 will not be build together, since
> compiler flags itself will be different.
Right, but we also need to deal with
> Can you elaborate on how things will break if multiple ARM architectures are
> selected?
>
> I am not sure whether I am following you completely.
We have quite a few initcalls that exit early with various soc_is, cpu_is,
cpu_class_is tests that would fail for multi zImage kernels. Some of these
have been patched away with additional calls in MACHINE_START, but some
still remain.
We probably always need to return false for all soc_is_omapxxxx() unless
the SoC detection is initialized in id.c.
Regards,
Tony
next prev parent reply other threads:[~2012-07-10 9:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 13:22 [PATCH] ARM: OMAP2+: cpu: Make cpu_class_is_omap2 true for all non-omap1 platforms Vaibhav Hiremath
2012-06-14 14:33 ` Hiremath, Vaibhav
2012-06-27 13:39 ` Tony Lindgren
2012-06-27 13:50 ` Hiremath, Vaibhav
2012-06-27 13:58 ` Tony Lindgren
2012-06-27 15:27 ` Hiremath, Vaibhav
2012-06-27 16:17 ` Tony Lindgren
2012-06-27 20:33 ` Hiremath, Vaibhav
2012-07-10 8:41 ` Tony Lindgren
2012-07-10 9:10 ` Hiremath, Vaibhav
2012-07-10 9:18 ` Tony Lindgren [this message]
2012-07-10 9:25 ` Hiremath, Vaibhav
2012-07-10 9:43 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710091820.GR1122@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox